feat(api core): simplify from_rfc3339 methods - #9641
Merged
emar-kar merged 29 commits intoNov 13, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Two similar methods combined into one.
Re-write tests for the 'from_rfc3339_nanos' method.
Fix for coverage and lint failures.
restore previous version with testing regex first + cosmetic chgs for the descriptions
added test to check the deprecation warning
adjusted the condition for the 'from_rfc3339' method + warning fix
* deleted extra spaces
* 'if-else' statement restored to throw an exception * wrote additional tests to cover the exception
Two similar methods combined into one.
Re-write tests for the 'from_rfc3339_nanos' method.
Fix for coverage and lint failures.
restore previous version with testing regex first + cosmetic chgs for the descriptions
added test to check the deprecation warning
adjusted the condition for the 'from_rfc3339' method + warning fix
* deleted extra spaces
* 'if-else' statement restored to throw an exception * wrote additional tests to cover the exception
…-cloud-python into Methods-Combining
crwilcox
suggested changes
Nov 9, 2019
Comment thread
api_core/google/api_core/bidi.py
Comment thread
api_core/google/api_core/datetime_helpers.py
Outdated
Comment thread
api_core/google/api_core/protobuf_helpers.py
crwilcox
approved these changes
Nov 12, 2019
tseaver
approved these changes
Nov 12, 2019
This was referenced Jan 29, 2020
[CHANGE ME] Re-generated container to pick up changes in the API or client library generator.
#10256
Closed
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was reopened for the clearness of the provided changes. (Old one 8742)
Closes: #7676