FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(bigquery): add support of use_avro_logical_types for extract jobs by HemangChothani · Pull Request #9642 · googleapis/google-cloud-python · GitHub

feat(bigquery): add support of use_avro_logical_types for extract jobs - #9642

Merged
tswast merged 3 commits into
googleapis:masterfrom
MaxxleLLC:BigQuery_Add_use_avro_logical_types_for_extract_jobs
Nov 20, 2019
Merged

feat(bigquery): add support of use_avro_logical_types for extract jobs#9642
tswast merged 3 commits into
googleapis:masterfrom
MaxxleLLC:BigQuery_Add_use_avro_logical_types_for_extract_jobs

Conversation

Copy link
Copy Markdown
Contributor

Fixes #9624

HemangChothani requested a review from a team November 8, 2019 11:22
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2019

Copy link
Copy Markdown
Contributor Author

kokoro - BigQuery failure related to 9633 issue.

HemangChothani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 11, 2019
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 11, 2019

tswast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM once nit is addressed.

Comment thread bigquery/google/cloud/bigquery/job.py Outdated

plamut commented Nov 13, 2019
edited
Loading

Copy link
Copy Markdown
Contributor

@HemangChothani Thanks for the cleanup, let's add it to the original use_avro_logical_types() method, too (boy scouts and such).

Edit: Great, thanks!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BigQuery: Add support for use_avro_logical_types for extract jobs

5 participants


Back | FazBrowse Home | New Git URL