Update 'Client' to hold stack of connection/batch/transaction objects. - #976
Update 'Client' to hold stack of connection/batch/transaction objects.#976tseaver merged 3 commits into
Conversation
Sorry, something went wrong.
|
Sorry, something went wrong.
Objects pushe onto the client's '_connection_stack' must implement the 'Connection' API, but need not be subclasses of 'Connection'. [ci skip]
They must all be implement the "connection" API. I can't think of a better name.
list.append and list.pop are atomic operations, which means that the list won't be corrupted by separate threads calling _push_connection. Threads using different batch / transaction objects with the same client could end up mangling one another: if it matters, we could just use the gcloud._helpers._LocalStack instead.
I think so. I threw out a much bigger changeset and started over, but I think this is simpler / clearer. |
Sorry, something went wrong.
|
But Transaction doesn't implement the same API as Connection. Am I missing something? Are there other things that will go on this stack? Yeah the thread-safety issue is not resolved by this, can you file an issue so that we follow up? _LocalStack makes the stack local to only 1 thread? |
Sorry, something went wrong.
This comment was marked as spam.
|
LGTM other than small nit. I think the answer to my "is it expensive" question is "no", but maybe you can educate me. |
Sorry, something went wrong.
|
I have a fix for the test name on the next PR. ISTM that the expense of creating a thread-local object isn't really an issue for our Client, which will typically be constructed only at startup: the _BATCHES global is going away, so it will be net zero for the typical case. |
Sorry, something went wrong.
…h_stack Update 'Client' to hold stack of connection/batch/transaction objects.
|
Good call on net zero. |
Sorry, something went wrong.
* chore: Update gapic-generator-python to 1.26.2 PiperOrigin-RevId: 802200836 Source-Link: googleapis/googleapis@d300b15 Source-Link: googleapis/googleapis-gen@a1ff0ae Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTFmZjBhZTcyZGRjYjY4YTI1OTIxNWQ4Yzc3NjYxZTJjZGJiOWIwMiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* chore: Update gapic-generator-python to 1.26.2 PiperOrigin-RevId: 802200836 Source-Link: googleapis/googleapis@d300b15 Source-Link: googleapis/googleapis-gen@a1ff0ae Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTFmZjBhZTcyZGRjYjY4YTI1OTIxNWQ4Yzc3NjYxZTJjZGJiOWIwMiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* chore: remove unused files * remove post processing for .kokoro/docs * add new line
* chore: remove unused files * remove post processing for .kokoro/docs * add new line
Fix a minor typo in documentation. Co-authored-by: Anthonios Partheniou <partheniou@google.com> Co-authored-by: arithmetic1728 <58957152+arithmetic1728@users.noreply.github.com>
Type annotations were added in commit f8d4aaa335a0eef915e73596fc9b43b11d11be9f. For these annotations to be useful by library users, the package should install a py.typed file. This tells mypy and other tools to consume and use these types. For more details, see: https://mypy.readthedocs.io/en/stable/installed_packages.html#creating-pep-561-compatible-packages
This PR adds support for Python 3.14 to the library. Key changes include: - Adding Python 3.14 to the test matrix in `.github/workflows/unittest.yml`. - Updating `setup.py` to include the Python 3.14 classifier. - Adding `testing/constraints-3.14.txt`. - Updating `noxfile.py` to include 3.14 sessions, and set default to 3.14. - Updating `CONTRIBUTING.rst` to list Python 3.14 as a supported version. NOTE: The Kokoro Samples 3.14 check will fail. The docker container for running that session does not yet have Python 3.14 in it. That is being done in parallel. The fact that the Samples check does not pass should not prevent this from being merged. NOTE: tweaked a set of tests to no longer use pytz which was a transient dependency in the past but the library that used to install with it no longer does. Moved timezone info from pytz to the standard library's timezone module. --------- Co-authored-by: ohmayr <omairn@google.com> Co-authored-by: Tim Sweña (Swast) <swast@google.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.7.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620 <details><summary>pandas-gbq: 0.32.0</summary> ## [0.32.0](googleapis/python-bigquery-pandas@v0.31.1...v0.32.0) (2025-12-15) ### Features * Add support for Python 3.14 (#976) ([89b008d8](googleapis/python-bigquery-pandas@89b008d8)) ### Bug Fixes * boolean round-trip test and CSV datetime loading errors (#1000) ([d4431030](googleapis/python-bigquery-pandas@d4431030)) </details>
) Source-Link: googleapis/synthtool@d6103f4 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:39f0f3f2be02ef036e297e376fe3b6256775576da8a6ccb1d5eeb80f4c8bf8fb Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
See #944.