feat(automl): expose disable_early_stopping option for create_model - #9779
Merged
helinwang merged 1 commit intoNov 12, 2019
Merged
feat(automl): expose disable_early_stopping option for create_model#9779helinwang merged 1 commit into
helinwang merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
helinwang
force-pushed
the
early_stop
branch
from
79918bb to
ab47f56
Compare
November 12, 2019 21:07
Disable early stopping is turned off by default. It's defined in proto here: https://github.com/googleapis/google-cloud-python/blob/bfb4da8542981d2eedffe20f64e87ab528a17592/automl/google/cloud/automl_v1beta1/proto/tables.proto#L196 This PR: - exposes disable_early_stopping option for TablesClient.create_model. - changes the default value of create_model's parameter model_metadata from empty dict to None. Default parameter values in Python is non-intuitive: http://effbot.org/zone/default-values.htm
helinwang
force-pushed
the
early_stop
branch
from
ab47f56 to
f9ea0ee
Compare
November 12, 2019 21:51
sirtorry
approved these changes
Nov 12, 2019
This was referenced Jan 29, 2020
[CHANGE ME] Re-generated container to pick up changes in the API or client library generator.
#10256
Closed
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
…9779) Disable early stopping is turned off by default. It's defined in proto here: https://github.com/googleapis/google-cloud-python/blob/19ccb8527897caa9e4139a5c023a2e9b217a902b/automl/google/cloud/automl_v1beta1/proto/tables.proto#L196 This PR: - exposes disable_early_stopping option for TablesClient.create_model. - changes the default value of create_model's parameter model_metadata from empty dict to None. Default parameter values in Python is non-intuitive: http://effbot.org/zone/default-values.htm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable early stopping is turned off by default. It's defined in proto
here:
google-cloud-python/automl/google/cloud/automl_v1beta1/proto/tables.proto
Line 196 in bfb4da8
This PR:
from empty dict to None. Default parameter values in Python is
non-intuitive: http://effbot.org/zone/default-values.htm