Update batch/transaction/query to hold client. - #978
Merged
tseaver merged 6 commits intoJul 11, 2015
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Update batch/transaction to push themselves onto client's stack, rather than batches. Updated API-invoking methods to take 'client', rather than 'connection', falling back to the client held by self. See #944.
This was referenced Jul 10, 2015
Comment thread
gcloud/datastore/batch.py
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
|
All finished with review, will await your comments. |
Sorry, something went wrong.
Do it once, rather than in each property invocation. Addresses: #978 (comment) #978 (comment)
Copy link
Copy Markdown
Contributor
Author
|
@dhermes I think I have addressed everything. PTAL. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
tseaver
added a commit
that referenced
this pull request
Jul 11, 2015
…_client Update batch/transaction/query to hold client.
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Jul 21, 2015
See googleapis#978 for context.
parthea
added a commit
that referenced
this pull request
Sep 11, 2025
This was referenced Sep 12, 2025
Closed
Closed
parthea
added a commit
that referenced
this pull request
Sep 16, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 22, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
* tests: Add nox target to test against the old emulator. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
added a commit
that referenced
this pull request
Nov 26, 2025
parthea
pushed a commit
that referenced
this pull request
Mar 2, 2026
parthea
pushed a commit
that referenced
this pull request
Mar 6, 2026
* test: look for transaction info on child job, not parent job * clarify transaction_info docstring * use sphinx method directive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update batch/transaction to push themselves onto client's stack, rather
than batches.
Updated API-invoking methods to take 'client', rather than 'connection',
falling back to the client held by self.
See #944.