fix(videointelligence): revert #9440; make features a keyword parameter - #9810
Merged
busunkim96 merged 2 commits intoNov 15, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…r in `annotate_video`, update retry config, make AnnotateVideo nonidempotent (via synth) (googleapis#9440)" This reverts commit 9fd07ec.
dizcology
approved these changes
Nov 14, 2019
crwilcox
approved these changes
Nov 15, 2019
This was referenced Jan 29, 2020
[CHANGE ME] Re-generated container to pick up changes in the API or client library generator.
#10256
Closed
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
…eter (#9810) * Makes `features` a keyword parameter to annotate_video This reverts part of commit 853d6125082589fe3bf8a3f5b347507de73589da.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating this for a rollback.
Python sample code code was passing the keyword argument input_uri positionally before this change. Adding a required parameter changed the parameter order and broke existing code.
from google.cloud import videointelligence video_client = videointelligence.VideoIntelligenceServiceClient() features = [videointelligence.enums.Feature.LABEL_DETECTION] operation = video_client.annotate_video( 'gs://cloud-samples-data/video/cat.mp4', features=features) print('\nProcessing video for label annotations:') But I have a problem with the video annotation function, I get the following error message: TypeError Traceback (most recent call last) <ipython-input-24-5eb4216acaf7> in <module> 4 features = [videointelligence.enums.Feature.LABEL_DETECTION] 5 operation = video_client.annotate_video( ----> 6 'gs://cloud-samples-data/video/cat.mp4', features=features) 7 print('\nProcessing video for label annotations:') TypeError: annotate_video() got multiple values for argument 'features'Note: We're still debating what to do about this longer term. I may add a synth replace to make this semi-permanent until the transition to the microgenerator. Alternatively we may take this change but do a major version bump to indicate that it is breaking.