FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Replace optional connection with client in storage methods and functions. by dhermes · Pull Request #984 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

Replace optional connection with client in storage methods and functions. - #984

Merged
dhermes merged 11 commits into
googleapis:masterfrom
dhermes:replace-connection-in-storage
Jul 14, 2015
ConversationCommits (11)ChecksFiles changed
Merged

Replace optional connection with client in storage methods and functions.#984
dhermes merged 11 commits into
googleapis:masterfrom
dhermes:replace-connection-in-storage

Conversation

dhermes commented Jul 13, 2015

Copy link
Copy Markdown
Contributor

Towards #952.

Did this for all but Bucket.create (since it also requires a project, built for just a client)

Will continue to remove connection from the Bucket and Batch constructors in forthcoming PR.

dhermes added 11 commits July 13, 2015 12:10
Updating Blob.generate_signed_url to accept a client.
872a101 
Towards googleapis#952, removing connection from methods / constructors.
Updating Blob.exists to accept a client.
3905a5b 
Towards googleapis#952, removing connection from methods / constructors.
Updating Blob.download* methods to accept a client.
301bc1c 
Towards googleapis#952, removing connection from methods / constructors.

Also adding a temporary Blob._client_or_connection method
to allow switching from an explicit client to an implicit
connection.
Updating Blob.upload* and Bucket.upload* methods to accept a client.
83590a1 
Towards googleapis#952, removing connection from methods / constructors.
Updating Bucket.exists method to accept a client.
78b1d83 
Towards googleapis#952, removing connection from methods / constructors.

Also adding a temporary Bucket._client_or_connection method
to allow switching from an explicit client to an implicit
connection.
Updating Bucket.get_blob method to accept a client.
c012b31 
Towards googleapis#952, removing connection from methods / constructors.
Updating Bucket.copy_blob and Blob.rename methods to accept a client.
c30132b 
Towards googleapis#952, removing connection from methods / constructors.
Updating delete methods on Blob and Bucket to accept a client.
3c9b7e3 
Towards googleapis#952, removing connection from methods / constructors.
Updating Bucket.make_public and ACL.reload accept a client.
c309d0c 
Towards googleapis#952, removing connection from methods / constructors.
Updating storage.ACL methods to accept a client.
adb0bc1 
Also updating all code which calls those methods.

Towards googleapis#952, removing connection from methods / constructors.
Updating patch() and reload() storage methods to accept a client.
586274a 
Towards googleapis#952, removing connection from methods / constructors.
dhermes added the api: storage Issues related to the Cloud Storage API. label Jul 13, 2015
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 13, 2015
dhermes mentioned this pull request Jul 13, 2015
Closed
7 tasks

tseaver commented Jul 13, 2015

Copy link
Copy Markdown
Contributor

Hmm, before finishing review here, it feels to me like swapping out the connection=None for client=None is premature: shouldn't we establish a client attribute, so that we can fall back to using it? Otherwise we have to revisit all these methods when we do have the client attribute.

dhermes commented Jul 13, 2015

Copy link
Copy Markdown
Contributor Author

I just wanted to make a bunch of small commits so review was easier for you. I have the client attribute at the ready, it just takes a bit more effort to review (it reaches deep into many parts of the code).

dhermes commented Jul 13, 2015

Copy link
Copy Markdown
Contributor Author

@tseaver Can we push forward on this? I want to wrap up the client stuff and cut a release ASAP.

dhermes mentioned this pull request Jul 13, 2015
Merged

tseaver commented Jul 14, 2015

Copy link
Copy Markdown
Contributor

LGTM

dhermes commented Jul 14, 2015

Copy link
Copy Markdown
Contributor Author

@tseaver We've got an LGTM here but a few pending commets. Good to merge?

dhermes commented Jul 14, 2015

Copy link
Copy Markdown
Contributor Author

Oh I'm sorry 8b1ecb2 was in #987. Merging and will rebase that.

dhermes added a commit that referenced this pull request Jul 14, 2015
Merge pull request #984 from dhermes/replace-connection-in-storage
247899b 
Replace optional connection with client in storage methods and functions.
dhermes merged commit 247899b into googleapis:master Jul 14, 2015
dhermes deleted the replace-connection-in-storage branch July 14, 2015 14:54
dhermes mentioned this pull request Jul 21, 2015
Merged
parthea pushed a commit that referenced this pull request Nov 22, 2025
chore(docs): add async note to docs (#984)
9362b10
parthea pushed a commit that referenced this pull request Nov 24, 2025
chore: release 0.51.2 (#984)
13832b2 
🤖 I have created a release \*beep\* \*boop\*
---
### [0.51.2](https://www.github.com/googleapis/gapic-generator-python/compare/v0.51.1...v0.51.2) (2021-09-13)


### Bug Fixes

* add a separate DEFAULT_CLIENT_INFO for rest clients ([#988](https://www.github.com/googleapis/gapic-generator-python/issues/988)) ([22ac400](https://www.github.com/googleapis/gapic-generator-python/commit/22ac40097ab50bb2d3a7f1a2d35d659c391e0927))
* **snippetgen:** use f-strings in print statements ([#975](https://www.github.com/googleapis/gapic-generator-python/issues/975)) ([122e85c](https://www.github.com/googleapis/gapic-generator-python/commit/122e85c37ff6aa0a99f64361397eb3df5495a3b4))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea added a commit that referenced this pull request Nov 24, 2025
chore: librarian release pull request: 20251117T201128Z (#984)
d2ec487 
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.6.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620
<details><summary>pandas-gbq: 0.31.0</summary>

##
[0.31.0](googleapis/python-bigquery-pandas@v0.30.0...v0.31.0)
(2025-11-17)

### Features

* add pandas_gbq.sample (#983)
([ac771c12](googleapis/python-bigquery-pandas@ac771c12))

</details>

---------

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
chore: fix mypy check (#984)
b92a3ae
parthea pushed a commit that referenced this pull request Mar 2, 2026
chore(docs): add async note to docs (#984)
2d3a243
parthea added a commit that referenced this pull request Mar 9, 2026
build(deps): [autoapprove] bump certifi from 2022.12.7 to 2023.7.22 (#…
6e70a24 
…984)

Source-Link: googleapis/synthtool@395d53a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6c1cbc75c74b8bdd71dada2fa1677e9d6d78a889e9a70ee75b93d1d0543f96e1

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL