feat(storage): support optionsRequestedPolicyVersion - #9989
Merged
jkwlui merged 12 commits intoJan 13, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
jkwlui
requested review from
busunkim96,
crwilcox,
frankyn and
tseaver
as code owners
December 17, 2019 20:37
frankyn
reviewed
Dec 17, 2019
Comment thread
storage/google/cloud/storage/bucket.py
frankyn
reviewed
Dec 18, 2019
frankyn
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Overall LGTM, I have one nit question.
Sorry, something went wrong.
Comment thread
storage/tests/system.py
maintain compatibility with defaultdict remove in place raise KeyError on delete update deprecation for dict-key access and factory methods clean up maintain compatibility - removing duplicate in __setitems__ check for conditions for dict access remove empty binding fix test accessing private var _bindings fix(tests): change version to make existing tests pass tests: add tests for getitem, delitem, setitem on v3 and conditions test policy.bindings property fixlint black sort bindings by role when converting to api repr add deprecation warning for iam factory methods update deprecation message for role methods make Policy#bindings.members a set update policy docs fix docs make docs better fix: Bigtable policy class to use Policy.bindings add from_pb with conditions test add to_pb condition test blacken fix policy __delitem__ add docs on dict access do not modify binding in to_apr_repr
jkwlui
force-pushed
the
iam-proposal3
branch
from
74a32cc to
583ca42
Compare
December 19, 2019 21:16
jkwlui
force-pushed
the
storage-policy-version
branch
from
1badb64 to
c210d29
Compare
December 19, 2019 21:17
frankyn
approved these changes
Dec 19, 2019
frankyn
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
crwilcox
suggested changes
Dec 20, 2019
Comment thread
api_core/google/api_core/iam.py
Outdated
Comment thread
storage/tests/unit/test_bucket.py
jkwlui
force-pushed
the
iam-proposal3
branch
from
583ca42 to
6c9556d
Compare
December 21, 2019 00:56
Copy link
Copy Markdown
Contributor
Author
|
@crwilcox fixed the builds. Would you mind taking a look again? |
Sorry, something went wrong.
crwilcox
approved these changes
Jan 13, 2020
This was referenced Jan 29, 2020
Merged
Merged
Merged
[CHANGE ME] Re-generated container to pick up changes in the API or client library generator.
#10256
Closed
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
* iam proposal #3 maintain compatibility with defaultdict remove in place raise KeyError on delete update deprecation for dict-key access and factory methods clean up maintain compatibility - removing duplicate in __setitems__ check for conditions for dict access remove empty binding fix test accessing private var _bindings fix(tests): change version to make existing tests pass tests: add tests for getitem, delitem, setitem on v3 and conditions test policy.bindings property fixlint black sort bindings by role when converting to api repr add deprecation warning for iam factory methods update deprecation message for role methods make Policy#bindings.members a set update policy docs fix docs make docs better fix: Bigtable policy class to use Policy.bindings add from_pb with conditions test add to_pb condition test blacken fix policy __delitem__ add docs on dict access do not modify binding in to_apr_repr * feat(storage): support requested_policy_version for get_iam_policy * add system-test * add ref doc sample to get_iam_policy * add requested_policy_version to blob * fix tests * nit: typo * blacken * fix docs build * format docs * remove unused variables
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
* iam proposal #3 maintain compatibility with defaultdict remove in place raise KeyError on delete update deprecation for dict-key access and factory methods clean up maintain compatibility - removing duplicate in __setitems__ check for conditions for dict access remove empty binding fix test accessing private var _bindings fix(tests): change version to make existing tests pass tests: add tests for getitem, delitem, setitem on v3 and conditions test policy.bindings property fixlint black sort bindings by role when converting to api repr add deprecation warning for iam factory methods update deprecation message for role methods make Policy#bindings.members a set update policy docs fix docs make docs better fix: Bigtable policy class to use Policy.bindings add from_pb with conditions test add to_pb condition test blacken fix policy __delitem__ add docs on dict access do not modify binding in to_apr_repr * feat(storage): support requested_policy_version for get_iam_policy * add system-test * add ref doc sample to get_iam_policy * add requested_policy_version to blob * fix tests * nit: typo * blacken * fix docs build * format docs * remove unused variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #9869