Firestore Collection Group queries - #3416
Merged
quartzmo merged 2 commits intoMay 29, 2019
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
blowmage
approved these changes
May 24, 2019
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
quartzmo
force-pushed
the
firestore-collection-group
branch
from
213e042 to
c53c68f
Compare
May 28, 2019 16:23
Copy link
Copy Markdown
Member
Author
|
Rebased on master for build fix (#3417). |
Sorry, something went wrong.
schmidt-sebastian
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
This looks good to me. 25 lines of core logic is probably the new record for a new Firestore feature!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collection Group queries add support for queries to Firestore that query documents by collection ID rather than by collection path. With this feature, users can now query for documents in collections that share a name, no matter where these collection are located.
Java: googleapis/google-cloud-java#4652
Node: googleapis/nodejs-firestore#578
Python: googleapis/google-cloud-python#7758