FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ci: bad behavior change (no API change) by suztomo · Pull Request #1363 · googleapis/google-http-java-client · GitHub

/ google-http-java-client Public

ci: bad behavior change (no API change) #1363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
suztomo wants to merge 2 commits into from
Conversation 0 Commits 2 Checks 0 Files changed
Closed

ci: bad behavior change (no API change) #1363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56077c6
ci: test installing GitHub Actions for LTS Library Test
suztomo May 5, 2021
b95cd8e
ci: bad behavior change (no API change)
suztomo May 5, 2021
File filter

Filter by extension

Filter by extension .java  (1) .yaml  (1) All 2 file types selected
Only manifest files
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
45 changes: 45 additions & 0 deletions .github/workflows/lts-test.yaml
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
on:
# This should run for only pull requests for this repository's LTS branches
pull_request:
branches:
- '*-sp'
name: LTS Library Test
jobs:
lts-library-test:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
# Only the downstream of this libraries are needed
repository:
- beam
# - google-api-java-client This does not work for LTS BOM Test due to bintray decommission
- google-auth-library-java
- google-maps-services-java
- grpc-java
- java-bigquery
- java-bigtable-hbase
- java-monitoring
- java-pubsub
- java-spanner
- java-storage
- java-trace
steps:
- uses: actions/checkout@v2
- uses: actions/setup-java@v1
with:
java-version: 8
- name: Install this repository's artifacts to local Maven repository
run: |
mvn --batch-mode --show-version --no-transfer-progress install \
-DskipTests=true \
-Dclirr.skip=true \
-Denforcer.skip=true \
-Dmaven.javadoc.skip=true \
-Dgcloud.download.skip=true
# The lts_tests branch has not merged to master but it hosts GitHub Actions.
- uses: GoogleCloudPlatform/cloud-opensource-java/lts-test@lts_tests
with:
repository: ${{ matrix.repository }}
version_override_key: http.version
version_override_value: 1.39.2
2 changes: 1 addition & 1 deletion google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -876,7 +876,7 @@ public HttpResponse execute() throws IOException {
executeException = null;

// run the interceptor
if (executeInterceptor != null) {
if (executeInterceptor == null) { // This code is wrong. Just for testing.
executeInterceptor.intercept(this);
}
// build low-level HTTP request
Expand Down
Back | FazBrowse Home | New Git URL