FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Wrap GZIPInputStream with a ConsumingInputStream to drain on close by chingor13 · Pull Request #749 · googleapis/google-http-java-client · GitHub

/ google-http-java-client Public

Wrap GZIPInputStream with a ConsumingInputStream to drain on close - #749

Closed
chingor13 wants to merge 2 commits into
googleapis:masterfrom
chingor13:chunked-keepalive
ConversationCommits (2)ChecksFiles changed
Closed

Wrap GZIPInputStream with a ConsumingInputStream to drain on close#749
chingor13 wants to merge 2 commits into
googleapis:masterfrom
chingor13:chunked-keepalive

Conversation

chingor13 commented Jul 15, 2019

Copy link
Copy Markdown
Contributor

Fixes #367

chingor13 requested a review from a team July 15, 2019 23:40
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 15, 2019
elharo reviewed Jul 29, 2019
View reviewed changes
Comment thread google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java
return content;
}

static class ConsumingInputStream extends InputStream {

elharo Jul 29, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

An outer class would better separate unrelated code. This is complex enough to justify it.

Comment thread google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java
public void close() throws IOException {
if (!closed && inputStream != null) {
try {
drainInputStream(this);

elharo Jul 29, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why is it important to drain the input stream and throw away the excess data, instead of simply closing the stream?

Comment thread google-http-client/src/test/java/com/google/api/client/http/HttpResponseTest.java
try (ByteArrayOutputStream byteStream = new ByteArrayOutputStream(dataToCompress.length)) {
GZIPOutputStream zipStream = new GZIPOutputStream((byteStream));
zipStream.write(dataToCompress);
zipStream.close();

elharo Jul 29, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We should probably also have a case where there's extra data on the stream after the gzipped content, since handling that is the purpose of this PR.

elharo reviewed Jul 29, 2019
View reviewed changes
Comment thread google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java
}
}

static void drainInputStream(final InputStream inputStream) throws IOException {

elharo Jul 29, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think this method can be private. Also you've reinvented ByteStreams.exhaust from Guava.

codyoss added a commit to codyoss/google-http-java-client that referenced this pull request Oct 14, 2019
feat: wrap GZIPInputStream for connection reuse
d5a0de6 
If a connection is closed and there are some bytes that have not
been read that connection can't be reused. Now GZIPInputStream
will have all of its bytes read on close automatically to promote
connection reuse.

Checkpicked from: googleapis#749
Fixes: googleapis#367
codyoss added a commit to codyoss/google-http-java-client that referenced this pull request Oct 14, 2019
feat: wrap GZIPInputStream for connection reuse
756987a 
If a connection is closed and there are some bytes that have not
been read that connection can't be reused. Now GZIPInputStream
will have all of its bytes read on close automatically to promote
connection reuse.

Cherry-picked: googleapis#749
Fixes: googleapis#367
codyoss mentioned this pull request Oct 14, 2019
Merged
codyoss added a commit that referenced this pull request Oct 18, 2019
feat: wrap GZIPInputStream for connection reuse (#840)
087a428 
If a connection is closed and there are some bytes that have not
been read that connection can't be reused. Now GZIPInputStream
will have all of its bytes read on close automatically to promote
connection reuse.

Cherry-picked: #749
Fixes: #367
chingor13 closed this Oct 22, 2019
chingor13 deleted the chunked-keepalive branch October 22, 2019 00:37
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this pull request Aug 11, 2022
fix: timing of stale token refreshes on ComputeEngine (googleapis#749)
c813d55 
* fix: timing of stale token refreshes on ComputeEngine

ComputeEngine metadata server has its own token caching mechanism that will return a cached token until the last 5 minutes of its expiration. This has a negative interaction with stale token refreshes because stale token refresh kicks in T-6mins until T-5mins. This will cause every stale refresh to return the same stale token.

This PR updates the timing for ComputeEngineCredentials to start a stale refresh at T-4mins and consider the token expired at T-3 mins. The implementation is a bit noisy because it includes a change OAuth2Credentials to make the thresholds configureable and now that we targeting java8, I migrated to using java8 time data types

* fmt

* fix test

* fix test again

* remove debug code

* comments
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this pull request Aug 11, 2022
chore: release 1.2.0 (googleapis#747)
39cca92 
🤖 I have created a release \*beep\* \*boop\*
---
## [1.2.0](https://www.github.com/googleapis/google-auth-library-java/compare/v1.1.0...v1.2.0) (2021-09-30)


### Features

* add support for Workforce Pools ([googleapis#729](https://www.github.com/googleapis/google-auth-library-java/issues/729)) ([5f3fed7](https://www.github.com/googleapis/google-auth-library-java/commit/5f3fed79e22f3c2d585c5b03c01791b0f8109929))


### Bug Fixes

* allow empty workforce_pool_user_project ([googleapis#752](https://www.github.com/googleapis/google-auth-library-java/issues/752)) ([e1cbce1](https://www.github.com/googleapis/google-auth-library-java/commit/e1cbce1a5cb269c6613bc6d40f06145bd45099c0))
* timing of stale token refreshes on ComputeEngine ([googleapis#749](https://www.github.com/googleapis/google-auth-library-java/issues/749)) ([c813d55](https://www.github.com/googleapis/google-auth-library-java/commit/c813d55a78053ecbec1a9640e6c9814da87319eb))
* workforce audience ([googleapis#741](https://www.github.com/googleapis/google-auth-library-java/issues/741)) ([a08cacc](https://www.github.com/googleapis/google-auth-library-java/commit/a08cacc7990b9058c8f1af3f9d8d816119562cc4))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
elharo elharo left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

chunked encoding + GZIP prevents keep-alive

3 participants

Back | FazBrowse Home | New Git URL