FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: add a check for partial response data by cojenco · Pull Request #435 · googleapis/google-resumable-media-python · GitHub

This repository was archived by the owner on May 6, 2026. It is now read-only.
/ google-resumable-media-python Public archive

fix: add a check for partial response data - #435

Merged
cojenco merged 4 commits into
googleapis:mainfrom
cojenco:incomplete-reads
May 31, 2024
ConversationCommits (4)ChecksFiles changed
Merged

fix: add a check for partial response data#435
cojenco merged 4 commits into
googleapis:mainfrom
cojenco:incomplete-reads

Conversation

cojenco commented May 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Handle corner cases of incomplete downloads with a 200 response code. These are rare cases when a download is prematurely terminated due to network stability or bandwidth throttling etc, but does not result in connection reset errors. The library will

  • (1) compare the # bytes read vs x-goog-stored-content-length header
  • (2) raise a retry-able ConnectionError in the aim to trigger a retry

Add more context to checksum mismatch error message that will help with debugging

  • bytes read from the download request (tracked within the Download object)
  • X-Goog-Stored-Content-Length value from the response header
  • X-Goog-Stored-Content-Encoding value from the response header

Fixes internal b/278011003

cojenco requested review from a team May 14, 2024 21:41
product-auto-label Bot added the size: m Pull request size is medium. label May 14, 2024
product-auto-label Bot added the api: storage Issues related to the googleapis/google-resumable-media-python API. label May 14, 2024
cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label May 14, 2024
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 14, 2024
cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label May 15, 2024
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 15, 2024
cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label May 15, 2024
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 15, 2024
cojenco changed the title chore: update checksum mismatch error message with additional context fix: add a check for partial response data May 15, 2024
cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label May 16, 2024
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 16, 2024
cojenco requested a review from andrewsg May 30, 2024 23:12
andrewsg approved these changes May 30, 2024
View reviewed changes

andrewsg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

danielduhh commented May 31, 2024

Copy link
Copy Markdown

Is this good to merge? @cojenco

cojenco merged commit aaea392 into googleapis:main May 31, 2024
release-please Bot mentioned this pull request May 31, 2024
Merged
cojenco added a commit to cojenco/python-storage that referenced this pull request May 22, 2025
fix: import googleapis/google-resumable-media-python#435
3e3a7ad
cojenco mentioned this pull request May 22, 2025
Merged
cojenco added a commit to googleapis/python-storage that referenced this pull request May 28, 2025
fix: add a check for partial response data (#1487)
7e0412a 
* fix: import googleapis/google-resumable-media-python#435

* update expections as per #1283
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
andrewsg andrewsg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

bajajneha27

Labels

api: storage Issues related to the googleapis/google-resumable-media-python API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL