FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

refactor(bigquery): Clean up sample test resources, fix comments by whuffman36 · Pull Request #3823 · googleapis/java-bigquery · GitHub

This repository was archived by the owner on Mar 23, 2026. It is now read-only.
/ java-bigquery Public archive

refactor(bigquery): Clean up sample test resources, fix comments #3823

Merged
whuffman36 merged 2 commits into from
Jun 4, 2025
Conversation 1 Commits 2 Checks 0 Files changed
Merged

refactor(bigquery): Clean up sample test resources, fix comments #3823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39cd054
refactor(bigquery): Clean up sample test resources, fix comments
whuffman36 Jun 2, 2025
220599f
fix style
whuffman36 Jun 2, 2025
File filter

Filter by extension

Filter by extension .java  (5) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
3 changes: 0 additions & 3 deletions google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryImpl.java
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -441,9 +441,6 @@ public com.google.api.services.bigquery.model.Job call() throws IOException {
&& createException.getCause() != null
&& createException.getCause().getMessage() != null) {

/*GoogleJsonResponseException createExceptionCause =
(GoogleJsonResponseException) createException.getCause();*/

Pattern pattern = Pattern.compile(".*Already.*Exists:.*Job.*", Pattern.CASE_INSENSITIVE);
Matcher matcher = pattern.matcher(createException.getCause().getMessage());

Expand Down
2 changes: 1 addition & 1 deletion google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/QueryJobConfiguration.java
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ private Builder(com.google.api.services.bigquery.model.JobConfiguration configur
this();
JobConfigurationQuery queryConfigurationPb = configurationPb.getQuery();
this.query = queryConfigurationPb.getQuery();
// Allows to get undeclaredqueryparameters in jobstatistics2
// Allows to get undeclared query parameters in jobstatistics
if (queryConfigurationPb.getQueryParameters() == null
&& queryConfigurationPb.getParameterMode() != null) {
parameterMode = queryConfigurationPb.getParameterMode();
Expand Down
6 changes: 2 additions & 4 deletions google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -208,10 +208,8 @@ public Dataset createSkipExceptionTranslation(Dataset dataset, Map<Option, ?> op
.insert(dataset.getDatasetReference().getProjectId(), dataset)
.setPrettyPrint(false)
.setFields(Option.FIELDS.getString(options));
for (Map.Entry<Option, ?> entry : options.entrySet()) {
if (entry.getKey() == Option.ACCESS_POLICY_VERSION && entry.getValue() != null) {
bqCreateRequest.setAccessPolicyVersion((Integer) entry.getValue());
}
if (options.containsKey(Option.ACCESS_POLICY_VERSION)) {
bqCreateRequest.setAccessPolicyVersion((Integer) options.get(Option.ACCESS_POLICY_VERSION));
}
return bqCreateRequest.execute();
}
Expand Down
10 changes: 4 additions & 6 deletions google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -1334,7 +1334,7 @@ public void testUpdateDatasetWithSelectedFields() {
}

@Test
public void testUpdateDatabaseWithAccessPolicyVersion() throws IOException {
public void testUpdateDatasetWithAccessPolicyVersion() throws IOException {
String accessPolicyDataset = RemoteBigQueryHelper.generateDatasetName();
ServiceAccountCredentials credentials =
(ServiceAccountCredentials) GoogleCredentials.getApplicationDefault();
Expand Down Expand Up @@ -1827,7 +1827,7 @@ public void testCreateDatasetWithAccessPolicyVersion() throws IOException {
}

@Test(expected = BigQueryException.class)
public void testCreateDatabaseWithInvalidAccessPolicyVersion() throws IOException {
public void testCreateDatasetWithInvalidAccessPolicyVersion() throws IOException {
String accessPolicyDataset = RemoteBigQueryHelper.generateDatasetName();
ServiceAccountCredentials credentials =
(ServiceAccountCredentials) GoogleCredentials.getApplicationDefault();
Expand Down Expand Up @@ -4040,8 +4040,7 @@ public void testBQResultSetPagination() throws SQLException {
assertEquals(300000, cnt); // total 300000 rows should be read
}

// @Test - Temporarily disabling till https://github.com/googleapis/gax-java/issues/1712 or
// b/235591056 are resolved
@Test
public void testReadAPIIterationAndOrder()
throws SQLException { // use read API to read 300K records and check the order
String query =
Expand Down Expand Up @@ -4240,8 +4239,7 @@ public void testCreateDefaultConnection() throws BigQuerySQLException {
assertTrue(connection.close());
}

// @Test - Temporarily disabling till https://github.com/googleapis/gax-java/issues/1712 or
// b/235591056 are resolved
@Test
public void testReadAPIConnectionMultiClose()
throws
SQLException { // use read API to read 300K records, then closes the connection. This test
Expand Down
1 change: 1 addition & 0 deletions samples/snippets/src/test/java/com/example/bigquery/GrantViewAccessIT.java
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ public void tearDown() {
DeleteTable.deleteTable(viewDatasetName, viewName);
DeleteTable.deleteTable(viewDatasetName, tableName);
DeleteDataset.deleteDataset(PROJECT_ID, datasetName);
DeleteDataset.deleteDataset(PROJECT_ID, viewDatasetName);
// restores print statements in the original method
System.out.flush();
System.setOut(originalPrintStream);
Expand Down
Back | FazBrowse Home | New Git URL