Summary of Changes

Hello @AbgarSim, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant modernization effort by migrating the project's testing infrastructure from JUnit 4 to JUnit 5. This transition not only updates the core testing framework but also introduces parallel test execution, aiming to drastically improve the speed and efficiency of the test suite. The changes span across dependency management, test class annotations, and assertion method usage, ensuring full compatibility with the latest JUnit platform features.

Highlights

• Migration to JUnit 5: The project's testing framework has been upgraded from JUnit 4 to JUnit 5. This involved updating core JUnit dependencies and adapting test annotations and assertion methods across numerous test files to align with the JUnit 5 API.
• Parallel Test Execution: Parallel execution of tests has been enabled by introducing a junit-platform.properties file. This configuration sets up concurrent execution for test classes and methods with a fixed parallelism of 8, aiming to significantly improve test suite performance.
• Mockito Integration Update: Mockito integration has been updated for JUnit 5 by adding the mockito-junit-jupiter dependency. Existing @RunWith(MockitoJUnitRunner.class) annotations were replaced with @ExtendWith(MockitoExtension.class) to ensure compatibility and leverage JUnit 5's extension model.
• Assertion Modernization: JUnit 4 static assertion methods from org.junit.Assert (e.g., assertEquals, assertNotNull, fail) have been replaced with their JUnit 5 counterparts from org.junit.jupiter.api.Assertions for improved readability and consistency.
• Lifecycle Method Updates: JUnit 4 test lifecycle annotations such as @Before and @BeforeClass have been migrated to their JUnit 5 equivalents, @BeforeEach and @BeforeAll respectively, providing clearer semantics for test setup and teardown.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Thanks again @AbgarSim, really appreciate the work going into migrating to JUnit 5! The tests generally look good. I added a few comments mostly about dependencies.

For the the wildcard imports (import static org.junit.jupiter.api.Assertions.*;, can you break them down into the individual imports that are used?

Additionally, we have the dependencies check reporting:

Error:  Used undeclared dependencies found:
Error:     org.junit.jupiter:junit-jupiter-api:jar:5.11.4:test
Error:     junit:junit:jar:4.13.2:test
Error:  Unused declared dependencies found:
Error:     org.junit.jupiter:junit-jupiter:jar:5.11.4:test

Hi @lqiu96 thanks for the feedback!

I've pushed the following adjustments:

• Deleted junit-platform.properties - will move it as separate PR
• Adjusted all the Assertion.* imports, good catch missed those
• Used the junit-vintage-engine.version for junit dep - as per my comment above please advice if this is ok
• Split JUnit Jupiter into explicit junit-jupiter-api and junit-jupiter-engine, this should address the dependencies check

• Used the junit-vintage-engine.version for junit dep - as per my comment above please advice if this is ok

Ah, I think I may have misremembered. I think you're right since the parent pom is shared-configs not shared-deps. In that case, I don't think you'll be able to use the property. I do see that junit v5 is already managed via shared-deps (we bring that in already). In that case, can you try and remove junit-jupiter from the BQ's parent-pom as it can be managed via shared-deps?

Also, I see that we have two mockito deps. Can we try and use a mockito Bom in the parent pom? Perhaps see if we can use v5.21.0? I think this would different from the version in shared-deps so we can try and manage the version locally for now. I think those two should work and the rest LGTM.

Besides that, thank you for all your work! :) I'll just ask that we wait until my colleague comes back next week to give this a second pair of eyes before merging.

@lqiu96 Thanks again for the review and happy to help!

I do see that junit v5 is already managed via shared-deps (we bring that in already). In that case, can you try and remove junit-jupiter from the BQ's parent-pom as it can be managed via shared-deps?

Done

Also, I see that we have two mockito deps. Can we try and use a mockito Bom in the parent pom? Perhaps see if we can use v5.21.0? I think this would different from the version in shared-deps so we can try and manage the version locally for now.

Removed mockito deps and added mockito Bom v5.21.0

Thanks, I took a look at the CI and I think there are a few minor things

• Linter is complaining, I think we just need to run mvn fmt again
• Dependencies CI is complaining:

Error:  Unused declared dependencies found:
Error:     org.junit.jupiter:junit-jupiter-engine:jar:5.11.4:test

Is it possible to remove junit-jupiter-engine from the pom? I think that should satisfy the CI (it may also be a false flag)

• CI is complaining about Mockito 5.x requiring Java 11 minimum for the Java 8 test. Apologies, can we downgrade this to mockito v4.11.0? It's a test dependency, but we haven't split the source JDK requirement version and from any test JDK requirements.

Changes LGTM. I'll approve after these which I think should fix everything. Thanks again!

Thanks, I took a look at the CI and I think there are a few minor things

• Linter is complaining, I think we just need to run mvn fmt again
• Dependencies CI is complaining:

Error:  Unused declared dependencies found:
Error:     org.junit.jupiter:junit-jupiter-engine:jar:5.11.4:test

Is it possible to remove junit-jupiter-engine from the pom? I think that should satisfy the CI (it may also be a false flag)

• CI is complaining about Mockito 5.x requiring Java 11 minimum for the Java 8 test. Apologies, can we downgrade this to mockito v4.11.0? It's a test dependency, but we haven't split the source JDK requirement version and from any test JDK requirements.

Changes LGTM. I'll approve after these which I think should fix everything. Thanks again!

This is done

• Ran the mvn fmt:format -T 1C command
• Removed the junit-jupiter-engine from POM
• Downgraded mockito BOM to 4.11.0

/gcbrun

Looks like Graalvm is complaining:

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] 
[INFO] --- native:0.10.6:test (test-native) @ google-cloud-bigquery ---
[ERROR] Test configuration file wasn't found. Make sure that test execution wasn't skipped.

Not sure why. Taking a look...

Looks like Graalvm is complaining:

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] 
[INFO] --- native:0.10.6:test (test-native) @ google-cloud-bigquery ---
[ERROR] Test configuration file wasn't found. Make sure that test execution wasn't skipped.

Not sure why. Taking a look...

Looking online it says that junit-jupiter-engine is required to run these tests. Though the dependencies check seems to complain that it's unused.

Ok, I don't think we can get around this complaint from dependencies check. I'll look about trying to disable (or remove) the failOnWarning check so that this can get merged in. I think we will need junit-jupiter-engine to run the tests.

Looking at the CI for the non-graalvm tests, I see this in the logs:

[INFO] --- surefire:3.5.2:test (default-test) @ google-cloud-bigquery ---
[INFO] Tests are skipped.

@AbgarSim Apologies for the additional reverting work 😆. It seems like we will need the junit-jupiter-engine dep for the tests the run. Would you be able to add it back in and pull the latest changes (I also added in configs to ignore the failed dependencies checks earlier).

Thanks @AbgarSim, this is done in #4052

Thanks @AbgarSim, this is done in #4052

Thanks! Created follow up in this #4058