deps: update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 - #6
Conversation
Sorry, something went wrong.
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
Sorry, something went wrong.
|
iam dependency is failing. Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project proto-google-cloud-bigquerydatapolicy-v1beta1: Compilation failure: Compilation failure: Error: /home/runner/work/java-bigquerydatapolicy/java-bigquerydatapolicy/proto-google-cloud-bigquerydatapolicy-v1beta1/src/main/java/com/google/cloud/bigquery/datapolicies/v1beta1/DataPolicyProto.java:[182,32] package com.google.iam.v1 does not exist Error: /home/runner/work/java-bigquerydatapolicy/java-bigquerydatapolicy/proto-google-cloud-bigquerydatapolicy-v1beta1/src/main/java/com/google/cloud/bigquery/datapolicies/v1beta1/DataPolicyProto.java:[183,32] package com.google.iam.v1 does not exist Error: /home/runner/work/java-bigquerydatapolicy/java-bigquerydatapolicy/proto-google-cloud-bigquerydatapolicy-v1beta1/src/main/java/com/google/cloud/bigquery/datapolicies/v1beta1/DataPolicyProto.java:[272,22] package com.google.iam.v1 does not exist |
Sorry, something went wrong.
|
Issue inside grpc-google-cloud-bigquerydatapolicy-v1beta1 [INFO] --- maven-dependency-plugin:3.3.0:analyze (default-cli) @ grpc-google-cloud-bigquerydatapolicy-v1beta1 --- Warning: Used undeclared dependencies found: Warning: com.google.api.grpc:proto-google-iam-v1:jar:1.6.2:compile Pulled in from shared-dependencies -- Output from mvn help:effective-pom -Dverbose=true <dependency> <groupId>com.google.api.grpc</groupId> <!-- com.google.cloud:first-party-dependencies:3.0.4, line 166 --> <artifactId>proto-google-iam-v1</artifactId> <!-- com.google.cloud:first-party-dependencies:3.0.4, line 167 --> <version>1.6.2</version> <!-- com.google.cloud:first-party-dependencies:3.0.4, line 168 --> </dependency> Is not an issue for any other split repo? Or do all of the grpc-* modules use iam? |
Sorry, something went wrong.
|
Looking at another split repo with the same setup (IAM in proto-*/): https://github.com/googleapis/java-asset/blob/ca33b8a69524616531df651c9980b8ede0a2f80e/proto-google-cloud-asset-v1/pom.xml#L34 This isn't raising any dependencies check issue. Running mvn help:effective-pom -Dverbose shows that iam is being included in from shared-dependencies. Searching in the grpc-*/ folder and there are no references to iam being used at all. Not sure why it isn't throwing any issues. Going to running the dependencies check locally and see the issues. Issue seems odd that it only affects this split repo... unless there is something unique about this repo? This is affecting all the other PRs in this repo: #1 (comment) |
Sorry, something went wrong.
|
I guess you are looking at dependencyManagement section. The error is complaining about dependencies section. |
Sorry, something went wrong.
@suztomo I only see one reference to proto-google-iam-v1 in the grpc-google-cloud-asset-v1 module when generating the effective-pom. The effective-pom is showing that's it's pulled in via shared-dependencies in the <dependencyManagement> section of the effective-pom. Am I missing something? |
Sorry, something went wrong.
|
I'm just going to manually exclude the iam library from grpc-*/ modules. If we need this again in the future, we can manually remove the exclusions. <exclusions>
<exclusion>
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-iam-v1</artifactId>
</exclusion>
</exclusions>
Now running into this issue: Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project grpc-google-cloud-bigquerydatapolicy-v1beta1: Compilation failure: Compilation failure: Error: /home/runner/work/java-bigquerydatapolicy/java-bigquerydatapolicy/grpc-google-cloud-bigquerydatapolicy-v1beta1/src/main/java/com/google/cloud/bigquery/datapolicies/v1beta1/DataPolicyServiceGrpc.java:[274,28] package com.google.iam.v1 does not exist IAM Library is clearly being used: |
Sorry, something went wrong.
|
Ok, I believe I found the issue: Warning: Used undeclared dependencies found: Warning: com.google.api.grpc:proto-google-iam-v1:jar:1.6.2:compile
I misread that as unused declared -- which made me think it was being pulled in Adding in the com.google.api.grpc:proto-google-iam-v1:jar:1.6.2:compile dependency should fix this. |
Sorry, something went wrong.
This PR contains the following updates:
⚠ Dependency Lookup Warnings ⚠
Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.