FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: enable hermetic library generation by diegomarquezp · Pull Request #2515 · googleapis/java-bigquerystorage · GitHub

This repository was archived by the owner on Feb 24, 2026. It is now read-only.

feat: enable hermetic library generation - #2515

Merged
diegomarquezp merged 13 commits into
googleapis:mainfrom
diegomarquezp:main
Jun 30, 2024
Merged

feat: enable hermetic library generation#2515
diegomarquezp merged 13 commits into
googleapis:mainfrom
diegomarquezp:main

Conversation

diegomarquezp commented May 28, 2024
edited
Loading

Copy link
Copy Markdown
Contributor

This is part of the effort to enable multi-version support in hand-written libraries. More context and details in this doc.

This PR adds two workflows and their scripts:

  • update_generation_config which updates generation_config.yaml (added in this PR) to contain the latest googleapis_committish (source of truth of library generation) as well as other dependencies such as gapic_generator_version. This job runs nightly and creates a PR that modifies the config yaml.
  • hermetic_library_generation which reads generation_config.yaml and pushes a new commit to any PR whose latest commit affects generation_config.yaml (e.g. the nightly PR created by update_generation_config). It essentially translates changes in the config yaml to changes in the source code (of the generated part). This workflow will be a required check.

As an example of how they work in practice:

  1. Once per night, update_generation_config creates a PR that updates generation_config.yaml with the latest dependencies and googleapis committish
  2. hermetic_library_generation is triggered by this PR and generates the corresponding code changes. A new commit with the code changes is added to the PR. This step may occur for any PR affecting generation_config.yaml.

Follow ups

  • Add CLOUD_JAVA_BOT_TOKEN to repository for the hermetic generation workflow to work

product-auto-label Bot added size: l Pull request size is large. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels May 28, 2024

conventional-commit-lint-gcf Bot commented Jun 3, 2024
edited
Loading

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • .github/workflows/ci.yaml
  • .github/workflows/samples.yaml

diegomarquezp force-pushed the main branch 3 times, most recently from c0979c0 to cec5749 Compare June 3, 2024 17:29
diegomarquezp marked this pull request as ready for review June 20, 2024 21:12
diegomarquezp requested review from a team June 20, 2024 21:12
Comment thread generation_config.yaml Outdated
Comment thread generation_config.yaml Outdated
diegomarquezp requested a review from blakeli0 June 26, 2024 01:27
diegomarquezp added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 28, 2024
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL