This repository was archived by the owner on Feb 24, 2026. It is now read-only.
feat: v1alpha client generation - #2615
Merged
gcf-merge-on-green[bot] merged 16 commits intoAug 27, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
blakeli0
approved these changes
Aug 21, 2024
Comment thread
.github/workflows/hermetic_library_generation.yaml
| jobs: | ||
| library_generation: | ||
| # skip pull requests coming from a forked repository | ||
| if: github.env.REPO_FULL_NAME == github.repository |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
@blakeli0 inlining the org/repo as an env var seems to break this if statement
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Probably because REPO_FULL_NAME is not referenced as a variable like $REPO_FULL_NAME?
Sorry, something went wrong.
blakeli0
reviewed
Aug 21, 2024
blakeli0
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
@PhongChuong Can we update the title to be a feat since the generated changes are also part of the PR?
Sorry, something went wrong.
Copy link
Copy Markdown
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Warning: This pull request is touching the following templated files:
|
Sorry, something went wrong.
Linchin
approved these changes
Aug 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: