FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: update samples/stylecheck to use java 11 by PhongChuong · Pull Request #2681 · googleapis/java-bigquerystorage · GitHub

This repository was archived by the owner on Feb 24, 2026. It is now read-only.
/ java-bigquerystorage Public archive

build: update samples/stylecheck to use java 11 - #2681

Merged
PhongChuong merged 1 commit into
mainfrom
samplesStyleJava11
Oct 3, 2024
ConversationCommits (1)ChecksFiles changed
Merged

build: update samples/stylecheck to use java 11#2681
PhongChuong merged 1 commit into
mainfrom
samplesStyleJava11

Conversation

PhongChuong commented Oct 3, 2024

Copy link
Copy Markdown
Contributor

This is to match new style guide as indicated in: https://github.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md#java-version

This fixes the samples/stylecheck in PR#2649

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

PhongChuong requested review from a team and Neenu1995 October 3, 2024 16:33

generated-files-bot Bot commented Oct 3, 2024

Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • .github/workflows/samples.yaml

product-auto-label Bot added size: xs Pull request size is extra small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. samples Issues that are directly related to samples. labels Oct 3, 2024
PhongChuong requested a review from whuffman36 October 3, 2024 16:34
whuffman36 approved these changes Oct 3, 2024
View reviewed changes

whuffman36 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

PhongChuong merged commit aaf1c2f into main Oct 3, 2024
PhongChuong deleted the samplesStyleJava11 branch October 3, 2024 17:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Neenu1995 Awaiting requested review from Neenu1995
1 more reviewer
whuffman36 whuffman36 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. samples Issues that are directly related to samples. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL