This repository was archived by the owner on May 8, 2026. It is now read-only.
fix: fix retry info algorithm setting - #2562
Merged
gcf-merge-on-green[bot] merged 7 commits intoApr 28, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
mutianf
marked this pull request as draft
April 23, 2025 20:28
mutianf
marked this pull request as ready for review
April 24, 2025 16:29
Comment thread
tpc-test/src/main/java/Main.java
Outdated
Copy link
Copy Markdown
Contributor
|
Is it feasible to add a test for this scenario? e.g. the actual behaviour of the retry when getting error retry delay = 1 -> error retry delay = 2 -> error with no retry delay |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Yeah, in the conformance test once we decide what to do! |
Sorry, something went wrong.
andre-sampaio
approved these changes
Apr 24, 2025
Copy link
Copy Markdown
Contributor
|
lgtm! |
Sorry, something went wrong.
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Apr 28, 2025
🤖 I have created a release *beep* *boop* --- ## [2.58.0](https://togithub.com/googleapis/java-bigtable/compare/v2.57.3...v2.58.0) (2025-04-28) ### Features * Add deletion_protection support for LVs ([43c97a3](https://togithub.com/googleapis/java-bigtable/commit/43c97a3f430ee4ee90d46b3685ae50f13949831c)) * **bigtable:** Add integration tests for Materialized/Logical Views ([#2518](https://togithub.com/googleapis/java-bigtable/issues/2518)) ([4d3a7e6](https://togithub.com/googleapis/java-bigtable/commit/4d3a7e675b60ba6a3225a45b7463edff279f9bc4)) ### Bug Fixes * **deps:** Update the Java code generator (gapic-generator-java) to 2.56.2 ([43c97a3](https://togithub.com/googleapis/java-bigtable/commit/43c97a3f430ee4ee90d46b3685ae50f13949831c)) * Fix retry info algorithm setting ([#2562](https://togithub.com/googleapis/java-bigtable/issues/2562)) ([c424ccb](https://togithub.com/googleapis/java-bigtable/commit/c424ccba72a191609dc726ed67d03f0d330015fc)) * Use universe domain when creating the monitoring client ([#2570](https://togithub.com/googleapis/java-bigtable/issues/2570)) ([3b51e12](https://togithub.com/googleapis/java-bigtable/commit/3b51e1206a4f83078625705ed8d8a899839af1a9)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug in RetryInfo retry algorithm.
In the following scenario: error retry delay = 1, error retry delay = 2, error with no retry delay. Currently the client did not set retry delay duration which is default to 0 for the first attempt. This will cause all the subsequent attempts from the same error to not have any retry delay if the retry delay is not present.
The fix sets retry delay duration to be the retry delay from the last attempt. We'll decide if we want to change this behavior later.
Conformance test currently assumes that the client will reset the retry delay. So also disabling the conformance test for now.