FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(bigtable): Add integration tests for Materialized/Logical Views by ron-gal · Pull Request #2518 · googleapis/java-bigtable · GitHub

This repository was archived by the owner on May 8, 2026. It is now read-only.
/ java-bigtable Public archive

feat(bigtable): Add integration tests for Materialized/Logical Views - #2518

Merged
gcf-merge-on-green[bot] merged 23 commits into
googleapis:mainfrom
ron-gal:views_it
Apr 24, 2025
ConversationCommits (23)ChecksFiles changed
Merged

feat(bigtable): Add integration tests for Materialized/Logical Views#2518
gcf-merge-on-green[bot] merged 23 commits into
googleapis:mainfrom
ron-gal:views_it

Conversation

ron-gal commented Mar 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

product-auto-label Bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Mar 13, 2025
product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Mar 13, 2025
ron-gal changed the title feat(bigtable): Add integration tests for Materialized Views feat(bigtable): Add integration tests for Materialized/Logical Views Mar 13, 2025
ron-gal marked this pull request as ready for review April 22, 2025 19:28
ron-gal requested review from a team April 22, 2025 19:28
andre-sampaio reviewed Apr 23, 2025
View reviewed changes
Comment thread ...table/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableInstanceAdminClientIT.java Outdated
}

@Test
public void materializedViewTest() {

andre-sampaio Apr 23, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can we be a bit more descriptive in what we are testing? e.g. createUpdateAndDeleteMaterializedView

andre-sampaio Apr 23, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Also can we split these up so that when tests fail it is easier to see what failed

ron-gal Apr 23, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done

Comment thread ...table/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableInstanceAdminClientIT.java

andre-sampaio Apr 23, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

These should not be on tests for InstanceAdmin. We should probably either create a new suite or use BigtableTableAdminClientIT.java (I prefer we added a new test suite)

ron-gal Apr 23, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done

andre-sampaio Apr 23, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

ty! I think we can revert this file now?

ron-gal Apr 23, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I thought I did that >.> Done for realz!

Comment thread ...table/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableInstanceAdminClientIT.java Outdated
Comment thread ...table/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableInstanceAdminClientIT.java Outdated
Comment thread ...table/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableInstanceAdminClientIT.java Outdated
}

@Test
public void logicalViewTest() {

andre-sampaio Apr 23, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Same comments than for materialized views.

ron-gal Apr 23, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done

product-auto-label Bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Apr 23, 2025
andre-sampaio approved these changes Apr 23, 2025
View reviewed changes

andre-sampaio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm! can you double check we are not leaving any dangling resources before merging?

andre-sampaio added the automerge Merge the pull request once unit tests and other checks pass. label Apr 24, 2025
gcf-merge-on-green Bot merged commit 4d3a7e6 into googleapis:main Apr 24, 2025
gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 24, 2025
release-please Bot mentioned this pull request Apr 24, 2025
Merged
ron-gal deleted the views_it branch April 24, 2025 22:25
gcf-merge-on-green Bot pushed a commit that referenced this pull request Apr 28, 2025
chore(main): release 2.58.0 (#2564)
0af7d03 
🤖 I have created a release *beep* *boop*
---


## [2.58.0](https://togithub.com/googleapis/java-bigtable/compare/v2.57.3...v2.58.0) (2025-04-28)


### Features

* Add deletion_protection support for LVs ([43c97a3](https://togithub.com/googleapis/java-bigtable/commit/43c97a3f430ee4ee90d46b3685ae50f13949831c))
* **bigtable:** Add integration tests for Materialized/Logical Views ([#2518](https://togithub.com/googleapis/java-bigtable/issues/2518)) ([4d3a7e6](https://togithub.com/googleapis/java-bigtable/commit/4d3a7e675b60ba6a3225a45b7463edff279f9bc4))


### Bug Fixes

* **deps:** Update the Java code generator (gapic-generator-java) to 2.56.2 ([43c97a3](https://togithub.com/googleapis/java-bigtable/commit/43c97a3f430ee4ee90d46b3685ae50f13949831c))
* Fix retry info algorithm setting ([#2562](https://togithub.com/googleapis/java-bigtable/issues/2562)) ([c424ccb](https://togithub.com/googleapis/java-bigtable/commit/c424ccba72a191609dc726ed67d03f0d330015fc))
* Use universe domain when creating the monitoring client ([#2570](https://togithub.com/googleapis/java-bigtable/issues/2570)) ([3b51e12](https://togithub.com/googleapis/java-bigtable/commit/3b51e1206a4f83078625705ed8d8a899839af1a9))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
release-please Bot mentioned this pull request Dec 15, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
andre-sampaio andre-sampaio approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL