This repository was archived by the owner on May 8, 2026. It is now read-only.
feat: expose generated GAPIC admin client and freeze legacy surface - #2806
Merged
jinseopkim0 merged 7 commits intoFeb 27, 2026
Merged
feat: expose generated GAPIC admin client and freeze legacy surface#2806jinseopkim0 merged 7 commits into
jinseopkim0 merged 7 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This change adds a `getNewApi()` method to `BigtableTableAdminClient` which returns the underlying `BaseBigtableTableAdminClient`. By using composition, we expose the fully generated GAPIC client to users, allowing them to access the newest features and proto-based methods. This maintains the legacy client as a backward-compatible facade without risking method signature collisions. This addresses the legacy client integration phase of the Admin API GAPIC upgrade. Tracking Bug: b/475818901
Marks all existing legacy veneer methods in BigtableTableAdminClient with @ObsoleteApi, directing users to the new getNewApi() surface. This freezes the legacy API surface as planned in the GAPIC modernization effort. Tracking Bug: b/475818901
jinseopkim0
force-pushed
the
legacy-client-integration
branch
from
d22d899 to
abd35dd
Compare
February 25, 2026 19:35
lqiu96
reviewed
Feb 26, 2026
Comment thread
...loud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java
Outdated
lqiu96
reviewed
Feb 26, 2026
Comment thread
...loud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java
Outdated
lqiu96
approved these changes
Feb 26, 2026
lqiu96
approved these changes
Feb 27, 2026
jinseopkim0
added a commit
that referenced
this pull request
Mar 2, 2026
…surface Adds getBaseClient() to BigtableInstanceAdminClient and marks all legacy handwritten veneer methods as @ObsoleteApi. This mirrors the recent changes to BigtableTableAdminClient in #2806. Tracking Bug: b/475818901
This was referenced Mar 2, 2026
jinseopkim0
added a commit
that referenced
this pull request
Mar 2, 2026
* feat: expose generated GAPIC instance admin client and freeze legacy surface Adds getBaseClient() to BigtableInstanceAdminClient and marks all legacy handwritten veneer methods as @ObsoleteApi. This mirrors the recent changes to BigtableTableAdminClient in #2806. Tracking Bug: b/475818901 * chore: generate libraries at Mon Mar 2 19:27:28 UTC 2026 --------- Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrates the autogenerated BaseBigtableTableAdminClient into the existing legacy BigtableTableAdminClient using composition.
Changes:
Context:
As part of the Admin API GAPIC modernization, we want to direct users to the standardized, proto-based methods. We chose composition (getNewApi()) over inheritance (extends BaseBigtableTableAdminClient) to avoid method signature collisions between the generated convenience methods and the legacy handwritten methods (e.g., deleteTable(String)).
This freezes the legacy API surface while giving customers full access to new features natively.
Tracking Bug: b/475818901