FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: migrate to google-auth-library for pre-emptive oauth refresh by mutianf · Pull Request #3228 · googleapis/java-bigtable-hbase · GitHub

feat: migrate to google-auth-library for pre-emptive oauth refresh - #3228

Merged
gcf-merge-on-green[bot] merged 3 commits into
googleapis:bigtable-1.xfrom
mutianf:auth
Sep 24, 2021
Merged

feat: migrate to google-auth-library for pre-emptive oauth refresh#3228
gcf-merge-on-green[bot] merged 3 commits into
googleapis:bigtable-1.xfrom
mutianf:auth

Conversation

mutianf commented Sep 23, 2021
edited by igorbernstein2
Loading

Copy link
Copy Markdown
Contributor

Now that auth library bundles pre-emptive refresh, RefreshingOAuth2CredentialsInterceptor can be removed. Also, remove retry on UNAUTHENTICATED

mutianf requested a review from a team September 23, 2021 17:27
product-auto-label Bot added the api: bigtable Issues related to the googleapis/java-bigtable-hbase API. label Sep 23, 2021
google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2021
mutianf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 23, 2021
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 23, 2021

igorbernstein2 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm, but please expand your imports

igorbernstein2 changed the title chore: remove refreshing credentials interceptor feat: migrate to google-auth-library for pre-emptive oauth refresh Sep 24, 2021
mutianf added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 24, 2021
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 24, 2021
gcf-merge-on-green Bot merged commit 8031a29 into googleapis:bigtable-1.x Sep 24, 2021
gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 24, 2021
mutianf deleted the auth branch September 24, 2021 18:06
mutianf added a commit to mutianf/java-bigtable-hbase that referenced this pull request Sep 20, 2022
…oogleapis#3228)

Now that auth library bundles [pre-emptive refresh](googleapis/google-auth-library-java#646), RefreshingOAuth2CredentialsInterceptor can be removed. Also, remove retry on UNAUTHENTICATED
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/java-bigtable-hbase API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL