FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Modify the bazel.BUILD file by hand to include the compliance protos which are not autogenerated by gcf-owl-bot[bot] · Pull Request #791 · googleapis/java-containeranalysis · GitHub

This repository was archived by the owner on Sep 16, 2023. It is now read-only.
/ java-containeranalysis Public archive

fix: Modify the bazel.BUILD file by hand to include the compliance protos which are not autogenerated - #791

Merged
pattishin merged 2 commits into
mainfrom
owl-bot-b607fb54-53d0-4780-93ae-ddd79cdeab56
Mar 24, 2022
ConversationCommits (2)ChecksFiles changed
Merged

fix: Modify the bazel.BUILD file by hand to include the compliance protos which are not autogenerated#791
pattishin merged 2 commits into
mainfrom
owl-bot-b607fb54-53d0-4780-93ae-ddd79cdeab56

Conversation

gcf-owl-bot Bot commented Jan 7, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Regenerate this pull request now.

PiperOrigin-RevId: 420306668

Source-Link: googleapis/googleapis@9a8910e

Source-Link: https://github.com/googleapis/googleapis-gen/commit/24c9bfc4d59f50a49e22a6070d1c229f523defdc
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjRjOWJmYzRkNTlmNTBhNDllMjJhNjA3MGQxYzIyOWY1MjNkZWZkYyJ9

gcf-owl-bot Bot requested review from a team January 7, 2022 20:55
trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 7, 2022
product-auto-label Bot added the api: containeranalysis Issues related to the googleapis/java-containeranalysis API. label Jan 7, 2022
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 7, 2022
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 7, 2022
trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 7, 2022
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 7, 2022
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 7, 2022

parthea commented Jan 9, 2022 •
edited
Loading

Copy link
Copy Markdown

Wait for decision on cl/420316256

parthea added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jan 9, 2022
Neenu1995 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 10, 2022
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 10, 2022
averikitsch added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2022
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2022

gcf-owl-bot Bot commented Jan 18, 2022

Copy link
Copy Markdown
Contributor Author

Owl bot is regenerating pull request 791...
Build name: MDYzYTIxMmUtMTc5MS00MzA2LTk5NDktZTcyMTliMjNjOTEw

gcf-owl-bot Bot force-pushed the owl-bot-b607fb54-53d0-4780-93ae-ddd79cdeab56 branch from f3d5c0d to b5db9ce Compare January 18, 2022 18:09
trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 18, 2022
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 18, 2022
trusted-contributions-gcf Bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 18, 2022
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 18, 2022
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 18, 2022

gcf-owl-bot Bot commented Jan 20, 2022

Copy link
Copy Markdown
Contributor Author

Owl bot is regenerating pull request 791...
Build name: YWI1MDc2MDItZDIwMC00YzU3LWEyYWEtZDg2Y2I0Mzk1Njdh

gcf-owl-bot Bot force-pushed the owl-bot-b607fb54-53d0-4780-93ae-ddd79cdeab56 branch from 7917c42 to 0e05be9 Compare January 20, 2022 19:29
trusted-contributions-gcf Bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 20, 2022

gcf-merge-on-green Bot commented Feb 17, 2022

Copy link
Copy Markdown

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 17, 2022
meltsufin added the automerge Merge the pull request once unit tests and other checks pass. label Mar 8, 2022

gcf-merge-on-green Bot commented Mar 9, 2022

Copy link
Copy Markdown

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 9, 2022
meltsufin added the automerge Merge the pull request once unit tests and other checks pass. label Mar 10, 2022

gcf-merge-on-green Bot commented Mar 11, 2022

Copy link
Copy Markdown

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 11, 2022

suztomo commented Mar 17, 2022

Copy link
Copy Markdown
Member 
[INFO] --- maven-compiler-plugin:3.9.0:testCompile (default-testCompile) @ proto-google-cloud-containeranalysis-v1beta1 ---
[INFO] No sources to compile
[INFO] 
[INFO] --- animal-sniffer-maven-plugin:1.20:check (java8) @ proto-google-cloud-containeranalysis-v1beta1 ---
[INFO] Checking unresolved references to org.codehaus.mojo.signature:java18:1.0
[INFO] -------------------------------------------------------------
Error:  COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
Error:  /home/runner/work/java-containeranalysis/java-containeranalysis/proto-google-cloud-containeranalysis-v1/src/main/java/com/google/containeranalysis/v1/Containeranalysis.java:[118,28] cannot find symbol
  symbol:   class SeverityOuterClass
  location: package io.grafeas.v1
Error:  /home/runner/work/java-containeranalysis/java-containeranalysis/proto-google-cloud-containeranalysis-v1/src/main/java/com/google/containeranalysis/v1/Containeranalysis.java:[165,18] cannot find symbol
  symbol:   class SeverityOuterClass
  location: package io.grafeas.v1

suztomo reviewed Mar 17, 2022
View reviewed changes
Comment thread ...ud-containeranalysis-v1/src/main/java/com/google/containeranalysis/v1/Containeranalysis.java
io.grafeas.v1.Vulnerability.getDescriptor(),
io.grafeas.v1.Common.getDescriptor(),
io.grafeas.v1.GrafeasOuterClass.getDescriptor(),
io.grafeas.v1.SeverityOuterClass.getDescriptor(),

suztomo Mar 17, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This class is missing as per the compilation failure. #791 (comment)

Error:  /home/runner/work/java-containeranalysis/java-containeranalysis/proto-google-cloud-containeranalysis-v1/src/main/java/com/google/containeranalysis/v1/Containeranalysis.java:[118,28] cannot find symbol
  symbol:   class SeverityOuterClass
  location: package io.grafeas.v1

Comment thread ...ud-containeranalysis-v1/src/main/java/com/google/containeranalysis/v1/Containeranalysis.java
io.grafeas.v1.Vulnerability.getDescriptor();
io.grafeas.v1.Common.getDescriptor();
io.grafeas.v1.GrafeasOuterClass.getDescriptor();
io.grafeas.v1.SeverityOuterClass.getDescriptor();

suztomo Mar 17, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This class is missing as per the compilation failure. #791 (comment)

Error:  /home/runner/work/java-containeranalysis/java-containeranalysis/proto-google-cloud-containeranalysis-v1/src/main/java/com/google/containeranalysis/v1/Containeranalysis.java:[165,18] cannot find symbol
  symbol:   class SeverityOuterClass
  location: package io.grafeas.v1

Added question in cl/420306668

gcf-owl-bot Bot commented Mar 21, 2022

Copy link
Copy Markdown
Contributor Author

Owl bot is regenerating pull request 791...
Build name: MjIyMjdkODItOTFjMy00YzMwLThkYzAtNWRjYTZiMDExNTkz

suztomo commented Mar 21, 2022

Copy link
Copy Markdown
Member

It seems java-grafeas 2.2.2 is needed. Rebasing.

fix: Modify the bazel.BUILD file by hand to include the compliance pr…
f12cd24 
…otos which are not autogenerated

PiperOrigin-RevId: 420306668

Source-Link: googleapis/googleapis@9a8910e

Source-Link: https://github.com/googleapis/googleapis-gen/commit/24c9bfc4d59f50a49e22a6070d1c229f523defdc
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjRjOWJmYzRkNTlmNTBhNDllMjJhNjA3MGQxYzIyOWY1MjNkZWZkYyJ9
gcf-owl-bot Bot force-pushed the owl-bot-b607fb54-53d0-4780-93ae-ddd79cdeab56 branch from 8ddbb51 to f12cd24 Compare March 21, 2022 17:13
gcf-owl-bot Bot requested a review from a team March 21, 2022 17:13
trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 21, 2022
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 21, 2022
trusted-contributions-gcf Bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 21, 2022
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 21, 2022

suztomo commented Mar 21, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

The build is now green.

@parthea I saw you put 'Do not merge' label. Do you still have anything to be fixed?

parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 23, 2022

parthea commented Mar 23, 2022

Copy link
Copy Markdown

@Neenu1995 added do not merge but I see the bug b/217779626 is fixed. I've removed the label.

suztomo commented Mar 23, 2022

Copy link
Copy Markdown
Member

@googleapis/aap-dpes It's ready for your review.

release-please Bot mentioned this pull request Mar 24, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

5 more reviewers
suztomo suztomo left review comments
lesv lesv approved these changes
pattishin pattishin approved these changes
blakeli0 blakeli0 approved these changes
meltsufin meltsufin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: containeranalysis Issues related to the googleapis/java-containeranalysis API. owl-bot-copy owlbot:run Add this label to trigger the Owlbot post processor.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL