This repository was archived by the owner on Dec 3, 2023. It is now read-only.
[DO_NOT_MERGE]chore: downstream check for all libraries in single job - #621
Closed
Neenu1995 wants to merge 24 commits into
Closed
Neenu1995 wants to merge 24 commits into
Neenu1995 wants to merge 24 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Neenu1995
marked this pull request as draft
November 8, 2021 16:19
suztomo
reviewed
Jan 25, 2022
Comment thread
.kokoro/downstream-client-library-check.sh
lesv
approved these changes
Jan 25, 2022
lesv
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
a few suggestions, otherwise LGTM
Sorry, something went wrong.
Comment thread
.github/workflows/downstream.yaml
| fail-fast: false | ||
| matrix: | ||
| java: [17] | ||
| repo: |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
any comments? how to update, auto update, ?
Sorry, something went wrong.
Comment thread
.github/workflows/downstream.yaml
Comment thread
.kokoro/downstream-client-library-check.sh
Outdated
| cd ${scriptDir}/.. | ||
|
|
||
| # Make java core library artifacts available for 'mvn validate' at the bottom | ||
| mvn install -DskipTests=true -Dmaven.javadoc.skip=true -Dgcloud.download.skip=true -B -V -q |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
consider adding -ntp -fae
Sorry, something went wrong.
Comment thread
.kokoro/downstream-client-library-check.sh
Outdated
|
|
||
| # run dependencies script | ||
| cd .. | ||
| mvn -Denforcer.skip=true clean install |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
consider adding -ntp -fae
Sorry, something went wrong.
Comment thread
.kokoro/downstream-client-library-check.sh
Outdated
| popd | ||
| fi | ||
|
|
||
| mvn -Denforcer.skip=true clean install |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
consider adding -ntp -fae
Sorry, something went wrong.
suztomo
reviewed
Jan 25, 2022
Comment thread
.kokoro/downstream-client-library-check.sh
Outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.