FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add ReadOption.ReadTime to support timestamp reads. by yixiaoshen · Pull Request #712 · googleapis/java-datastore · GitHub

This repository was archived by the owner on Feb 24, 2026. It is now read-only.
/ java-datastore Public archive

feat: add ReadOption.ReadTime to support timestamp reads. - #712

Merged
gcf-merge-on-green[bot] merged 10 commits into
googleapis:mainfrom
yixiaoshen:ys-snapshot-read-v1
May 23, 2022
ConversationCommits (10)ChecksFiles changed
Merged

feat: add ReadOption.ReadTime to support timestamp reads.#712
gcf-merge-on-green[bot] merged 10 commits into
googleapis:mainfrom
yixiaoshen:ys-snapshot-read-v1

Conversation

yixiaoshen commented Apr 18, 2022

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

yixiaoshen requested review from a team April 18, 2022 18:33
product-auto-label Bot added size: m Pull request size is medium. api: datastore Issues related to the googleapis/java-datastore API. labels Apr 18, 2022
kolea2 reviewed Apr 21, 2022
View reviewed changes

kolea2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

looks good, can we also add an integration test?

kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 21, 2022
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 21, 2022
kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 12, 2022
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 12, 2022
kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 19, 2022
yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 19, 2022
yixiaoshen requested a review from kolea2 May 20, 2022 18:17
kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2022
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2022
kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2022
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2022
kolea2 added the automerge Merge the pull request once unit tests and other checks pass. label May 23, 2022
gcf-merge-on-green Bot merged commit 06bb08f into googleapis:main May 23, 2022
gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 23, 2022
release-please Bot mentioned this pull request May 23, 2022
Merged
yixiaoshen deleted the ys-snapshot-read-v1 branch May 23, 2022 19:18
gcf-merge-on-green Bot pushed a commit that referenced this pull request May 23, 2022
chore(main): release 2.5.0 (#729)
c04b37e 
🤖 I have created a release *beep* *boop*
---


## [2.5.0](v2.4.0...v2.5.0) (2022-05-23)


### Features

* add build scripts for native image testing in Java 17 ([#1440](#1440)) ([#739](#739)) ([252a174](252a174))
* add ReadOption.ReadTime to support timestamp reads. ([#712](#712)) ([06bb08f](06bb08f))


### Bug Fixes

* **java:** rename test to be picked up by native profile ([#723](#723)) ([3a30e75](3a30e75))


### Documentation

* **samples:** remove unused dependency ([#730](#730)) ([5185691](5185691))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.11.0 ([#737](#737)) ([8eb0c5f](8eb0c5f))
* update shared deps to 2.12.0 ([#740](#740)) ([5c3676e](5c3676e))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
kolea2 kolea2 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: datastore Issues related to the googleapis/java-datastore API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL