FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: Expose Datastore Admin generated client by pcostell · Pull Request #748 · googleapis/java-datastore · GitHub

This repository was archived by the owner on Feb 24, 2026. It is now read-only.
/ java-datastore Public archive

feat: Expose Datastore Admin generated client - #748

Merged
kolea2 merged 5 commits into
googleapis:mainfrom
pcostell:owl
May 31, 2022
Merged

feat: Expose Datastore Admin generated client#748
kolea2 merged 5 commits into
googleapis:mainfrom
pcostell:owl

Conversation

Copy link
Copy Markdown
Contributor

No description provided.

product-auto-label Bot added size: xl Pull request size is extra large. api: datastore Issues related to the googleapis/java-datastore API. labels May 25, 2022

Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/Key.java
  • proto-google-cloud-datastore-v1/src/main/proto/google/datastore/v1/entity.proto

pcostell force-pushed the owl branch 5 times, most recently from 75816ce to 384c707 Compare May 25, 2022 18:40
pcostell marked this pull request as ready for review May 25, 2022 20:09
pcostell requested review from a team May 25, 2022 20:09
kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 26, 2022
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 26, 2022
kolea2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 26, 2022
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 26, 2022
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 26, 2022
pcostell added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 26, 2022
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 26, 2022
pcostell force-pushed the owl branch 2 times, most recently from d71f4dc to e5b016e Compare May 27, 2022 04:07
product-auto-label Bot added size: s Pull request size is small. size: xl Pull request size is extra large. and removed size: xl Pull request size is extra large. size: s Pull request size is small. labels May 27, 2022
pcostell changed the title feat: Expose gapic & grpc clients for Datastore V1. feat: Expose Datastore Admin client May 27, 2022
pcostell added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2022
pcostell force-pushed the owl branch 2 times, most recently from 26638cc to 14e7b8a Compare May 27, 2022 16:35
Comment thread .repo-metadata.json
pcostell force-pushed the owl branch 3 times, most recently from a81ab5a to 32b1d7a Compare May 27, 2022 19:11
pcostell added the owlbot:run Add this label to trigger the Owlbot post processor. label May 27, 2022
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 27, 2022
pcostell added 2 commits May 27, 2022 14:16
Correct missing dependencies not generated by owl.
pcostell added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 27, 2022
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 27, 2022
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2022

Copy link
Copy Markdown
Contributor Author

I think actually ready for review now @kolea2, thanks for your help!

kolea2 changed the title feat: Expose Datastore Admin client feat: Expose Datastore Admin generated client May 31, 2022

kolea2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

looks great, one comment/question. Thanks!

Comment thread pom.xml Outdated
kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 31, 2022
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 31, 2022
kolea2 merged commit 3dd882a into googleapis:main May 31, 2022
This was referenced May 31, 2022
gcf-merge-on-green Bot pushed a commit that referenced this pull request May 31, 2022
🤖 I have created a release *beep* *boop*
---


## [2.6.0](v2.5.1...v2.6.0) (2022-05-31)


### Features

* Expose Datastore Admin generated client ([#748](#748)) ([3dd882a](3dd882a))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Copy link
Copy Markdown

Can we do the same for the regular Datastore client? There is no grpc-google-cloud-datastore-v1 unfortunetly.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: datastore Issues related to the googleapis/java-datastore API. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL