This repository was archived by the owner on Aug 13, 2026. It is now read-only.
feat: Implement SubscriberShutdownSettings - #2569
Merged
michaelpri10 merged 2 commits intoOct 7, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
chore: Format and cleanup sample chore: Remove hardcoded version from samples pom.xml
feywind
previously approved these changes
Oct 3, 2025
feywind
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
The logic looks good! I don't know as much about the Java library specifics, but I didn't see anything weird.
Sorry, something went wrong.
Comment thread
google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Subscriber.java
Outdated
feywind
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements subscriber shutdown options for the Java client library. This provides more control over the shutdown process: