FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: verifying test, lint, clirr, and graalvm in checks by suztomo · Pull Request #456 · googleapis/java-shared-config · GitHub

This repository was archived by the owner on Jul 14, 2026. It is now read-only.
/ java-shared-config Public archive

test: verifying test, lint, clirr, and graalvm in checks #456

Merged
suztomo merged 13 commits into from
Mar 29, 2022
Conversation 21 Commits 13 Checks 0 Files changed
Merged

test: verifying test, lint, clirr, and graalvm in checks #456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b75e431
test: verifying test, lint, and clirr in checks
suztomo Mar 28, 2022
a26f843
Merge remote-tracking branch 'origin/main' into lint_downstream
suztomo Mar 28, 2022
c344f2c
test: renaming job name
suztomo Mar 28, 2022
e9af28f
test: reverted dependencies job and adding build jobs
suztomo Mar 28, 2022
1c8a91a
ci: apt-get update before installing libxml2-utils
suztomo Mar 28, 2022
6219a7b
ci: adding the new builds as required checks
suztomo Mar 28, 2022
ea5a008
Merge remote-tracking branch 'origin/main' into lint_downstream
suztomo Mar 29, 2022
83941f6
test: trying graalvm job-type
suztomo Mar 29, 2022
8fc7aed
test: graalvm not for handwritten library
suztomo Mar 29, 2022
dc4cf3e
ci: setup graalvm
suztomo Mar 29, 2022
c5cd072
test: added comment and upgraded GitHub Actions
suztomo Mar 29, 2022
168cc88
ci: testing old GraalVM version
suztomo Mar 29, 2022
1d090e9
ci: using GraalVM 22.0.0.2
suztomo Mar 29, 2022
File filter

Filter by extension

Filter by extension .sh  (1) .yaml  (3) All 2 file types selected
Only manifest files
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
13 changes: 13 additions & 0 deletions .github/sync-repo-settings.yaml
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,19 @@ branchProtectionRules:
- "dependencies (11, java-spanner)"
- "dependencies (11, java-storage)"
- "dependencies (11, java-pubsub)"
- "build (8, java-trace, test)"
- "build (8, java-trace, lint)"
- "build (8, java-trace, clirr)"
- "build (8, java-bigquery, test)"
- "build (8, java-bigquery, lint)"
- "build (8, java-bigquery, clirr)"
- "build (11, java-trace, test)"
- "build (11, java-trace, lint)"
- "build (11, java-trace, clirr)"
- "build (11, java-bigquery, test)"
- "build (11, java-bigquery, lint)"
- "build (11, java-bigquery, clirr)"
- "graalvm (11, java-orgpolicy)"
- "cla/google"
- pattern: java7
# Can admins overwrite branch protection.
Expand Down
10 changes: 4 additions & 6 deletions .github/workflows/downstream.yaml → ...ub/workflows/downstream-dependencies.yaml
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,12 @@ jobs:
- java-storage
- java-pubsub
steps:
- uses: actions/checkout@v2
- uses: stCarolas/setup-maven@v4
with:
maven-version: 3.8.1
- uses: actions/setup-java@v1
- uses: actions/checkout@v3
- uses: actions/setup-java@v3
with:
distribution: zulu
java-version: ${{matrix.java}}
- run: java -version
- run: sudo apt-get update -y
- run: sudo apt-get install libxml2-utils
- run: .kokoro/client-library-check.sh ${{matrix.repo}}
- run: .kokoro/client-library-check.sh ${{matrix.repo}} dependencies
67 changes: 67 additions & 0 deletions .github/workflows/downstream-maven-plugins.yaml
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
on:
push:
branches:
- main
pull_request:

# Keeping this file separate as the dependencies check would use more
# repositories than needed this downstream check for GraalVM native image and
# other Maven plugins.
name: downstream
jobs:
build:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
java: [8, 11]
repo:
# GAPIC library
- java-trace
# Handwritten library
- java-bigquery
job-type:
- test # maven-surefire-plugin
- lint # fmt-maven-plugin and google-java-format
- clirr # clirr-maven-plugin
steps:
- uses: actions/checkout@v3
- uses: actions/setup-java@v3
with:
distribution: zulu
java-version: ${{matrix.java}}
- run: java -version
- run: sudo apt-get update -y
- run: sudo apt-get install libxml2-utils
- run: .kokoro/client-library-check.sh ${{matrix.repo}} ${{matrix.job-type}}

# GraalVM job ensures the compatibility of GraaVM version above and the
# native-maven-plugin version.
graalvm:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
java: [11]
repo:
# GAPIC library that doesn't use a real GCP project in integration tests
- java-orgpolicy
steps:
- uses: actions/checkout@v2
- uses: stCarolas/setup-maven@v4
with:
maven-version: 3.8.1
- uses: ayltai/setup-graalvm@v1

suztomo Mar 29, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@Neenu1995 @mpeddada1 Do we allow/ban this GitHub Actins?

Neenu1995 Mar 29, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

As long as it doesn't access our secrets we are fine with using any action. But this one looks like it is not being actively developed anymore. So may not be a good long term solution.

suztomo Mar 29, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks. I'll use this then.

I see the owner maintains the repository. https://github.com/ayltai/setup-graalvm/commits/master
When we need alternative we can just use curl and unzip the content.

Neenu1995 Mar 29, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

My bad. I saw the last release was in May 2021. Looks like it is being being actively developed.
with:
java-version: ${{matrix.java}}
# When a new version of native-maven-plugin fails to run in a downstream
# library, it's likely to be an incompatibility with the GraalVM version.
# In that case, you need to upgrade the Docker container used in the
# tests in the downstream repositories (not just this value below).
# Example: https://github.com/googleapis/testing-infra-docker/pull/195
graalvm-version: 22.0.0.2
Comment on lines +57 to +62

suztomo Mar 29, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Added an instruction on how to upgrade GraalVM version in testing-infra-docker.

mpeddada1 Mar 29, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you!
native-image: true
- run: java -version
- run: sudo apt-get update -y
- run: sudo apt-get install libxml2-utils
- run: .kokoro/client-library-check.sh ${{matrix.repo}} graalvm
23 changes: 19 additions & 4 deletions .kokoro/client-library-check.sh
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,15 @@ set -eo pipefail
# Display commands being run.
set -x

if [[ $# -lt 1 ]];
if [[ $# -ne 2 ]];
then
echo "Usage: $0 <repo-name>"
echo "Usage: $0 <repo-name> <job-type>"
echo "where repo-name is java-XXX and check-type is dependencies, lint, or clirr"
exit 1
fi
REPO=$1
# build.sh uses this environment variable
export JOB_TYPE=$2

## Get the directory of the build script
scriptDir=$(realpath $(dirname "${BASH_SOURCE[0]}"))
Expand Down Expand Up @@ -61,5 +64,17 @@ set ${VERSION}
save pom.xml
EOF

# run dependencies script
.kokoro/dependencies.sh
case ${JOB_TYPE} in
dependencies)
.kokoro/dependencies.sh
RETURN_CODE=$?
;;
*)
# This reads the JOB_TYPE environmental variable
.kokoro/build.sh
RETURN_CODE=$?
;;
esac

echo "exiting with ${RETURN_CODE}"
exit ${RETURN_CODE}
Back | FazBrowse Home | New Git URL