FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: Updating readme with new gfe latency metrics by KiranmayiB · Pull Request #1630 · googleapis/java-spanner · GitHub

This repository was archived by the owner on Apr 7, 2026. It is now read-only.
/ java-spanner Public archive

feat: Updating readme with new gfe latency metrics - #1630

Merged
ansh0l merged 2 commits into
googleapis:mainfrom
KiranmayiB:readmeupdate
Jan 11, 2022
Merged

feat: Updating readme with new gfe latency metrics#1630
ansh0l merged 2 commits into
googleapis:mainfrom
KiranmayiB:readmeupdate

Conversation

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

KiranmayiB requested review from a team January 6, 2022 08:31
product-auto-label Bot added the api: spanner Issues related to the googleapis/java-spanner API. label Jan 6, 2022

ansh0l left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm. But I see that #1629 is closed, would there be any changes further needed for samples after this one?

Copy link
Copy Markdown
Contributor Author

lgtm. But I see that #1629 is closed, would there be any changes further needed for samples after this one?

I closed #1629 as it was created accidentally. There wont be any changes after this.

Copy link
Copy Markdown
Contributor

@KiranmayiB do you want to update the opencensus version in the README as well? (https://github.com/googleapis/java-spanner/blob/main/.readme-partials.yaml#L86-L104)

Do you want to update the way we register the opencensus stackdriver collector configuration? (https://github.com/googleapis/java-spanner/blob/main/.readme-partials.yaml#L106-L116)

thiagotnunes added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 6, 2022
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 6, 2022
thiagotnunes added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2022
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2022
ansh0l merged commit d02601a into googleapis:main Jan 11, 2022
gcf-merge-on-green Bot pushed a commit that referenced this pull request Feb 4, 2022
🤖 I have created a release *beep* *boop*
---


## [6.18.0](v6.17.4...v6.18.0) (2022-02-03)


### Features

* add database dialect ([#1657](#1657)) ([269f090](269f090))
* Updating readme with new gfe latency metrics ([#1630](#1630)) ([d02601a](d02601a))


### Dependencies

* **java:** update actions/github-script action to v5 ([#1339](#1339)) ([#1659](#1659)) ([203b346](203b346))
* update actions/github-script action to v5 ([#1658](#1658)) ([a2f3790](a2f3790))
* update dependency com.google.cloud:google-cloud-monitoring to v3.2.1 ([#1637](#1637)) ([73c9434](73c9434))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.7.0 ([#1662](#1662)) ([ece31c0](ece31c0))
* update opencensus.version to v0.31.0 ([#1661](#1661)) ([1e86a3a](1e86a3a))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/java-spanner API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL