feat: add default end-to-end checksumming for JournalingBlobWriteSessionConfig - #3180
Closed
BenWhitehead wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
…ionConfig Create TestUtils.rmDashRm to recursively delete a directory, and update ITSyncAndUploadUnbufferedWritableByteChannelPropertyTest to use it. Add TmpDir auto closable to allow managed lifecycle of a temporary directory in a test. Remove md5Base64 from ChecksummedTestContent#toString(). Base64 values can contain path values that are not valid for filesystems. Add ITObjectChecksumSupportTest for journaling uploads. Update ITSyncAndUploadUnbufferedWritableByteChannelPropertyTest property tests to enable and expect crc32c values in all messages.
cojenco
approved these changes
Jul 9, 2025
cojenco
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM, had a GVC review session with Ben
Sorry, something went wrong.
BenWhitehead
added a commit
that referenced
this pull request
Jul 23, 2025
Merge train for * chore: cleanup Crc32cValue and associated Hasher operations #3167 * chore: add Hasher#defaultHasher() #3173 * chore: add UnifiedOpts.Opts#getHasher() to return a hasher relative to the set of Opts defined for an operation. #3174 * feat: add default end-to-end crc32c checksumming for several upload methods via grpc transport #3176 * feat: add default end-to-end checksumming for JournalingBlobWriteSessionConfig #3180 * fix: give user provided checksum precondition priority for Storage#create methods that accept byte[] #3182 * fix: move crc32c computation before writing to disk for BufferToDiskThenUpload BlobWriteSession config #3187
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create TestUtils.rmDashRm to recursively delete a directory, and update ITSyncAndUploadUnbufferedWritableByteChannelPropertyTest to use it.
Add TmpDir auto closable to allow managed lifecycle of a temporary directory in a test.
Remove md5Base64 from ChecksummedTestContent#toString(). Base64 values can contain path values that are not valid for filesystems.
Add ITObjectChecksumSupportTest for journaling uploads.
Update ITSyncAndUploadUnbufferedWritableByteChannelPropertyTest property tests to enable and expect crc32c values in all messages.