chore: cleanup Crc32cValue and associated Hasher operations - #3167
Closed
BenWhitehead wants to merge 3 commits into
Closed
chore: cleanup Crc32cValue and associated Hasher operations#3167BenWhitehead wants to merge 3 commits into
BenWhitehead wants to merge 3 commits into
Conversation
BenWhitehead
force-pushed
the
checksumming/02/crc32c-value-cleanup
branch
from
79c220f to
dbf4604
Compare
June 24, 2025 20:12
* Add `Crc32cValue#zero()` * `Crc32cValue.zero().concat(v) == v` * Update WriteCtx to use `Crc32cValue.zero()` as it's base values rather than `null` * Update Hasher.nullSafeConcat to account for the use of `zero` * if Hasher.noop() always return null * if Hasher.enabled() only return null if left side is null * Add nullability annotation to Crc32cValue.nullSafeConcat
… as it's base values rather than `null`'
…initial crc32c value The desired default will be `Crc32cValue.zero()`, but not all tests or uploads are ready to handle this. Stick with the existing null as default, and provide the overload to selectively opt into things incrementally.
BenWhitehead
force-pushed
the
checksumming/02/crc32c-value-cleanup
branch
from
454cf4b to
f97befb
Compare
June 25, 2025 22:36
cojenco
approved these changes
Jul 9, 2025
cojenco
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM, had a GVC review session with Ben
Sorry, something went wrong.
| /** | ||
| * TODO: Remove initialValue and replace with Crc32cValue.zero() once all uploads have been | ||
| * updated to do e2e checksumming by default. | ||
| */ |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Discussed in GVC; this is later updated in #3176
Sorry, something went wrong.
BenWhitehead
added a commit
that referenced
this pull request
Jul 23, 2025
Merge train for * chore: cleanup Crc32cValue and associated Hasher operations #3167 * chore: add Hasher#defaultHasher() #3173 * chore: add UnifiedOpts.Opts#getHasher() to return a hasher relative to the set of Opts defined for an operation. #3174 * feat: add default end-to-end crc32c checksumming for several upload methods via grpc transport #3176 * feat: add default end-to-end checksumming for JournalingBlobWriteSessionConfig #3180 * fix: give user provided checksum precondition priority for Storage#create methods that accept byte[] #3182 * fix: move crc32c computation before writing to disk for BufferToDiskThenUpload BlobWriteSession config #3187
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.