FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

samples: Add StorageControl Quickstart Sample by sydney-munro · Pull Request #2479 · googleapis/java-storage · GitHub

/ java-storage Public

samples: Add StorageControl Quickstart Sample - #2479

Merged
sydney-munro merged 9 commits into
mainfrom
storage-control
Apr 3, 2024
ConversationCommits (9)ChecksFiles changed
Merged

samples: Add StorageControl Quickstart Sample#2479
sydney-munro merged 9 commits into
mainfrom
storage-control

Conversation

sydney-munro commented Mar 29, 2024 •
edited by frankyn
Loading

Copy link
Copy Markdown
Contributor

Fixes #2477

sydney-munro requested review from a team March 29, 2024 20:18

snippet-bot Bot commented Mar 29, 2024 •
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

product-auto-label Bot added the size: m Pull request size is medium. label Mar 29, 2024

generated-files-bot Bot commented Mar 29, 2024 •
edited
Loading

Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • samples/install-without-bom/pom.xml
  • samples/snapshot/pom.xml
  • samples/snippets/pom.xml

product-auto-label Bot added api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. labels Mar 29, 2024
sydney-munro force-pushed the storage-control branch 2 times, most recently from 0197e9a to d39feb2 Compare April 1, 2024 15:45
sydney-munro added the owlbot:ignore instruct owl-bot to ignore a PR label Apr 1, 2024
frankyn reviewed Apr 1, 2024
View reviewed changes
Comment thread samples/snippets/src/main/java/com/example/storage/QuickstartStorageControlSample.java Outdated
Comment thread samples/snippets/src/main/java/com/example/storage/QuickstartStorageControlSample.java Outdated
public static void main(String... args) throws Exception {
String bucketName = args[0]; // "your-bucket-name";
StorageControlClient storageControlClient = StorageControlClient.create();
GetStorageLayoutRequest request = GetStorageLayoutRequest.newBuilder()

frankyn Apr 1, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

May help to clarify that _ represents global bucket namespace;

sydney-munro requested a review from frankyn April 3, 2024 15:04
frankyn reviewed Apr 3, 2024
View reviewed changes
Comment thread samples/snippets/src/main/java/com/example/storage/QuickstartStorageControlSample.java
@@ -28,9 +28,6 @@
public class QuickstartStorageControlSample {
public static void main(String... args) throws Exception {
String bucketName = args[0]; // "your-bucket-name";

frankyn Apr 3, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Linter will probably chime in but remove the imports for storage client as well

sydney-munro merged commit 3a0b829 into main Apr 3, 2024
sydney-munro deleted the storage-control branch April 3, 2024 18:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
frankyn frankyn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

minherz

Labels

api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for Storage Control Quickstart

3 participants

Back | FazBrowse Home | New Git URL