fix: update grpc WriteObject response handling to provide context when a failure happens - #2532
Merged
BenWhitehead merged 1 commit intoMay 8, 2024
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
…n a failure happens
BenWhitehead
force-pushed
the
grpc-stricter-response-validation-better-messages
branch
from
e4ad8c1 to
8bfc3f0
Compare
May 7, 2024 21:56
JesseLovelace
approved these changes
May 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #2527
This updated errors from grpc chunked uploads to have messages that include useful debugging information.
When a response is received but doesn't validate with the expected state:
com.google.cloud.storage.StorageException: Attempt to append to already finalized resumable session. |> [ |> com.google.storage.v2.WriteObjectRequest{ |> upload_id: uploadId |> checksummed_data: {range: [0:262144]} |> } |> ] | |< com.google.storage.v2.WriteObjectResponse{ |< resource { |< name: "obj" |< size: 524288 |< } |< } |When an error is returned by GCS:
com.google.cloud.storage.StorageException: Client side data loss detected. Attempt to append to a resumable session with an offset higher than the backend has |> [ |> com.google.storage.v2.WriteObjectRequest{ |> upload_id: uploadId |> checksummed_data: {range: [262144:524288]} |> } |> ] | |< Status{code=OUT_OF_RANGE, description=Upload request started at offset '262144', which is past expected offset '0'., cause=null} |< Metadata(content-type=application/grpc) |Also update exception propagation to add original call context as a suppressed exception in order to allow maintaining originating frames of the async failure.