FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: fix samples pom.xml issues by BenWhitehead · Pull Request #2660 · googleapis/java-storage · GitHub

/ java-storage Public

chore: fix samples pom.xml issues - #2660

Merged
BenWhitehead merged 1 commit into
mainfrom
fix-sample-xml
Aug 5, 2024
ConversationCommits (1)ChecksFiles changed
Merged

chore: fix samples pom.xml issues#2660
BenWhitehead merged 1 commit into
mainfrom
fix-sample-xml

Conversation

BenWhitehead commented Aug 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Close dependencies element for storage_install_with_bom
  • Remove release please comment for storage control from storage_install_without_bom. Instead, allow renovate-bot to update when the version is available in maven central.
  • remove duplicate declaration of google-cloud-storage-control in install-without-bom/pom.xml

chore: fix samples pom.xml issues
b958d08 
* Close dependency element for `storage_install_with_bom`
* Remove release please comment for storage control from `storage_install_without_bom`. Instead, allow renovate-bot to update when the version is available in maven central.
* remove duplicate declaration of `google-cloud-storage-control` in install-without-bom/pom.xml
BenWhitehead added the owlbot:ignore instruct owl-bot to ignore a PR label Aug 5, 2024
BenWhitehead requested review from a team August 5, 2024 18:49

snippet-bot Bot commented Aug 5, 2024

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

generated-files-bot Bot commented Aug 5, 2024

Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • samples/install-without-bom/pom.xml
  • samples/snippets/pom.xml

product-auto-label Bot added size: s Pull request size is small. api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. labels Aug 5, 2024
BenWhitehead merged commit 48e7a4c into main Aug 5, 2024
BenWhitehead deleted the fix-sample-xml branch August 5, 2024 19:48
diegomarquezp mentioned this pull request Aug 16, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
danielduhh danielduhh approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR samples Issues that are directly related to samples. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL