feat: allow specifying an expected object size for resumable operations. - #2661
feat: allow specifying an expected object size for resumable operations.#2661BenWhitehead merged 1 commit into
Conversation
Sorry, something went wrong.
| && ed.getErrorInfo() != null | ||
| && ed.getErrorInfo().getReason().equals("GRPC_MISMATCHED_UPLOAD_SIZE"))) { | ||
| clientDetectedError( | ||
| ResumableSessionFailureScenario.SCENARIO_5.toStorageException( |
There was a problem hiding this comment.
can we get some comments around what Scenario 5 is to make it easier to read?
Sorry, something went wrong.
There was a problem hiding this comment.
oh i see this was there before as well. my apologies. that can be a followup.
Sorry, something went wrong.
There was a problem hiding this comment.
ResumableSessionFailureScenario is an enum that is shared by several of our upload implementations and defines the types of failure scenarios that can happen when processing an upload request.
SCENARIO_5 is client side data loss detected
Sorry, something went wrong.
| && ed.getErrorInfo() != null | ||
| && ed.getErrorInfo().getReason().equals("GRPC_MISMATCHED_UPLOAD_SIZE"))) { | ||
| clientDetectedError( | ||
| ResumableSessionFailureScenario.SCENARIO_5.toStorageException( |
There was a problem hiding this comment.
oh i see this was there before as well. my apologies. that can be a followup.
Sorry, something went wrong.
Update resumable upload failure detection to be more specific about classifying a request as SCENARIO_5 Fixes #2511
Update resumable upload failure detection to be more specific about classifying a request as SCENARIO_5
Fixes #2511