chore: Any changes to the hermetic build inputs should trigger re-regeneration - #2762
Merged
BenWhitehead merged 1 commit intoOct 8, 2024
Merged
chore: Any changes to the hermetic build inputs should trigger re-regeneration#2762BenWhitehead merged 1 commit into
BenWhitehead merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
BenWhitehead
approved these changes
Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any changes to the hermetic build inputs should trigger re-regeneration, hence add all of them to paths in hermetic_library_generation.yaml. This is to resolve an issue found yesterday that hermetic code generation was not triggered in this PR #2755.
We don't have paths configured for any other handwritten libraries. IIRC, it was added for a special use case in Storage, @BenWhitehead can you please verify the changes in this PR does not affect other use cases?