feat: create(Blob) instrumentation - #2792
Merged
sydney-munro merged 6 commits intoOct 29, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
sydney-munro
force-pushed
the
otel-it-testing
branch
from
8cc3a2b to
3856854
Compare
October 24, 2024 21:59
sydney-munro
force-pushed
the
otel-it-testing
branch
from
9efdd37 to
8fe835b
Compare
October 24, 2024 22:26
frankyn
reviewed
Oct 24, 2024
frankyn
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
still reviewing adding one question; I see it's WIP; are you ready for review?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
not yet just testing some stuff out as the testbench integration is a pain to sort out locally. |
Sorry, something went wrong.
sydney-munro
commented
Oct 24, 2024
sydney-munro
marked this pull request as draft
October 25, 2024 17:44
sydney-munro
force-pushed
the
otel-it-testing
branch
from
023a996 to
3543adf
Compare
October 25, 2024 19:43
sydney-munro
marked this pull request as ready for review
October 25, 2024 19:56
frankyn
approved these changes
Oct 28, 2024
frankyn
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Have couple of comments; but LGTM, approving; feel free to merge after addressing them.
Sorry, something went wrong.
Comment thread
google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageImpl.java
Outdated
Comment thread
google-cloud-storage/src/test/java/com/google/cloud/storage/ITGrpcOpenTelemetryTest.java
Outdated
Comment thread
...e/src/test/java/com/google/cloud/storage/ParallelCompositeUploadWritableByteChannelTest.java
Outdated
sydney-munro
force-pushed
the
otel-it-testing
branch
2 times, most recently
from
cc8dc4b to
8e2dc67
Compare
October 28, 2024 22:10
sydney-munro
force-pushed
the
otel-it-testing
branch
from
8e2dc67 to
b4d2591
Compare
October 28, 2024 22:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.