feat: Instrument Reader and Writer methods - #2829
Merged
sydney-munro merged 2 commits intoDec 6, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human! -- conventional-commit-lint bot |
Sorry, something went wrong.
sydney-munro
commented
Nov 27, 2024
Comment thread
google-cloud-storage/src/test/java/com/google/cloud/storage/it/runner/registry/TestBench.java
| @@ -16,6 +16,7 @@ | |||
|
|
|||
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
This is adding back code that was removed for local development.
Sorry, something went wrong.
sydney-munro
force-pushed
the
reader-otel
branch
from
3e41d6f to
43f0069
Compare
November 27, 2024 19:00
JesseLovelace
approved these changes
Dec 5, 2024
sydney-munro
force-pushed
the
reader-otel
branch
from
43f0069 to
342afc3
Compare
December 6, 2024 21:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR also adds back testbench support that was previously removed for local development.