chore: misc otel internalization/cleanup - #2835
Merged
sydney-munro merged 1 commit intoDec 5, 2024
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
BenWhitehead
commented
Dec 5, 2024
| CreateBucketRequest req = opts.createBucketsRequest().apply(builder).build(); | ||
| GrpcCallContext merge = Utils.merge(grpcCallContext, Retrying.newCallContext()); | ||
| try (OpenTelemetryTraceUtil.Scope unused = otelSpan.makeCurrent()) { | ||
| try (OpenTelemetryTraceUtil.Scope ignored = otelSpan.makeCurrent()) { |
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
renamed variables to remove warnings from intellij.
Sorry, something went wrong.
BenWhitehead
commented
Dec 5, 2024
Comment thread
google-cloud-storage/src/main/java/com/google/cloud/storage/otel/OpenTelemetryInstance.java
| this.openTelemetry = storageOptions.getOpenTelemetrySdk(); | ||
| this.tracer = | ||
| openTelemetry.getTracer(LIBRARY_NAME, GaxProperties.getLibraryVersion(this.getClass())); | ||
| this.tracer = openTelemetry.getTracer(LIBRARY_NAME, storageOptions.getLibraryVersion()); |
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
Switch to using the logic from storageOptions rather than gax. Our version is more stable to repackaging, and is what is used for headers and such. We will want to keep them in sync.
Sorry, something went wrong.
BenWhitehead
commented
Dec 5, 2024
Comment thread
google-cloud-storage/src/main/java/com/google/cloud/storage/otel/OpenTelemetryInstance.java
| spanBuilder.setAllAttributes( | ||
| Attributes.builder() | ||
| .put("gcp.client.version", GaxProperties.getLibraryVersion(this.getClass())) | ||
| .put("gcp.client.version", storageOptions.getLibraryVersion()) |
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
ditto
Sorry, something went wrong.
BenWhitehead
commented
Dec 5, 2024
Comment thread
google-cloud-storage/src/main/java/com/google/cloud/storage/otel/OpenTelemetryInstance.java
| .put("gcp.client.version", storageOptions.getLibraryVersion()) | ||
| .put("gcp.client.repo", "googleapis/java-storage") | ||
| .put("gcp.client.artifact", "com.google.cloud.google-cloud-storage") | ||
| .put("gcp.client.artifact", "com.google.cloud:google-cloud-storage") |
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
use the maven package format
Sorry, something went wrong.
sydney-munro
approved these changes
Dec 5, 2024
sydney-munro
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM, thanks for taking care of that!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.