FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: add BidiUploadStreamingStream by BenWhitehead · Pull Request #3223 · googleapis/java-storage · GitHub

/ java-storage Public

chore: add BidiUploadStreamingStream #3223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BenWhitehead wants to merge 1 commit into from
Conversation 6 Commits 1 Checks 16 Files changed
Closed

chore: add BidiUploadStreamingStream #3223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .java  (9) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
11 changes: 11 additions & 0 deletions google-cloud-storage/src/main/java/com/google/cloud/storage/BidiUploadState.java
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,17 @@ abstract class BidiUploadState {
// seal this class to extension
private BidiUploadState() {}

@VisibleForTesting
BidiUploadState(String testName) {

BrandonY Aug 11, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Seems odd to need a visible-for-testing constructor of an abstract class, but presumably it'll make sense further down.

BenWhitehead Aug 12, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is here to facilitate validating some of the behavioral interactions from the BidiStream to the State where getting into a specific state would otherwise be difficult with the actual concrete implementation.

For example, in this test

java-storage/google-cloud-storage/src/test/java/com/google/cloud/storage/BidiUploadTest.java

Lines 1947 to 1951 in 365bce5

void updateFromRedirect(@NonNull BidiWriteObjectRedirectedError r) {
assertThat(beforeRedirectCalled.get()).isTrue();
assertThat(r).isEqualTo(redirect);
updateFromRedirectCalled.set(true);
}
we are verifying that the redirect is routed to the state by the response observer, whereas doing that same validation with the concrete class would require more involved setup and validation.
// some runtime enforcement that this constructor is only called from a test
// if we had java9+ we could seal this all the way without this hack
StackTraceElement[] stackTrace = Thread.currentThread().getStackTrace();
boolean isJunitTest =
Arrays.stream(stackTrace).anyMatch(ste -> ste.getClassName().startsWith("org.junit"));

checkState(isJunitTest, "not a junit test", testName);
}

protected final StorageException err(
UploadFailureScenario scenario, BidiWriteObjectResponse response) {
BidiWriteObjectRequest t = peekLast();
Expand Down
Loading
Loading
Back | FazBrowse Home | New Git URL