fix: update otel integration to properly activate span context for lazy RPCs such as reads & writes - #3255
Merged
BenWhitehead merged 1 commit intoAug 21, 2025
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
…zy RPCs such as reads & writes * Fixes for WriteChannel * Fixes for RadChannel * Fixes for BlobWriteSession * Fixes for BlobReadSession `s$com.google.cloud.storage.Storage/readAs$com.google.cloud.storage.Storage/blobReadSession/readAs$g` * Fixes for BlobAppendableUpload
cojenco
approved these changes
Aug 21, 2025
Comment thread
google-cloud-storage/src/main/java/com/google/cloud/storage/OtelStorageDecorator.java
Comment on lines
+1673
to
1678
| public void setScope() { | ||
| if (scope != null) { | ||
| clearScope(); | ||
| } | ||
| scope = span.makeCurrent(); | ||
| } |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This looks great! TIL to have explicit scope handling added to properly activate spans for lazy RPCs
Sorry, something went wrong.
BenWhitehead
added a commit
that referenced
this pull request
Aug 21, 2025
Accidentally opened after some debugging in #3255
BenWhitehead
added a commit
that referenced
this pull request
Aug 21, 2025
Accidentally opened after some debugging in #3255
BenWhitehead
added a commit
that referenced
this pull request
Sep 4, 2025
…zy RPCs such as reads & writes The initial attempt at this could leak scope and result in new spans being nested incorrectly. This approach attempts to be less clever, but bounds all scopes so there isn't any leaking. Followup to #3255
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to these fixes the grpc/call/interceptCall could end up orphaned from the span that the RPC was actually performed for.
Now it looks like the following (The interceptCall is properly parented by the createFrom span):
