fix: update BlobReadSession channels to not implicitly close once EOF is observed - #3344
Merged
BenWhitehead merged 1 commit intoOct 21, 2025
Merged
fix: update BlobReadSession channels to not implicitly close once EOF is observed#3344BenWhitehead merged 1 commit into
BenWhitehead merged 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
… is observed This allows a channel to be read, and EOF(-1) returned multiple times rather than receiving a ClosedChannelException after the first EOF is returned.
BenWhitehead
force-pushed
the
fix/brs/channel-eof
branch
from
82e0e65 to
622d41f
Compare
October 10, 2025 22:00
ShreyasSinha
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows a channel to be read, and EOF(-1) returned multiple times rather than receiving a ClosedChannelException after the first EOF is returned.