| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| Expand Up | @@ -696,6 +696,15 @@ public BlobWriteChannel writer(URL signedURL) { | |
| return new BlobWriteChannel(getOptions(), signedURL); | ||
| } | ||
|
|
||
| @Override | ||
| public void abort(WriteChannel channel) { | ||
| if (!(channel instanceof BlobWriteChannel)) { | ||
|
Comment thread
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Qualitywhy not make the method argument a BlobWriteChannel then?
Sorry, something went wrong.
All reactions
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality@elharo BlobWriteChannel is a package-private class. If it were public we could invoke channel.abort() directly.
Sorry, something went wrong.
All reactions
|
||
| throw new IllegalArgumentException("channel is not created by Storage"); | ||
| } | ||
| BlobWriteChannel blobWriteChannel = (BlobWriteChannel) channel; | ||
| blobWriteChannel.cancelUpload(); | ||
| } | ||
|
|
||
| private BlobWriteChannel writer(BlobInfo blobInfo, BlobTargetOption... options) { | ||
| final Map<StorageRpc.Option, ?> optionsMap = optionMap(blobInfo, options); | ||
| return new BlobWriteChannel(getOptions(), blobInfo, optionsMap); | ||
| Expand Down | ||
| Back | FazBrowse Home | New Git URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityYet again, we're getting stuck because of excessive use of interfaces. Either there are multiple implementations of Storage and we shouldn't make this change or we should bite the bullet and combine Storage and StorageImpl once and for all. Ditto StorageRpc and HttpStorageRpc.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality@frankyn what do you think about combining Storage and StorageImpl?
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.