This repository was archived by the owner on Mar 4, 2026. It is now read-only.
Adding DocumentSnapshot support for Cursors - #100
Merged
schmidt-sebastian merged 3 commits intoJan 12, 2018
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 1601 1642 +41
=====================================
+ Hits 1601 1642 +41
Continue to review full report at Codecov.
|
Sorry, something went wrong.
schmidt-sebastian
force-pushed
the
mrschmidt-cursors
branch
from
6cb95f6 to
6ef7760
Compare
January 10, 2018 01:27
mikelehen
suggested changes
Jan 10, 2018
mikelehen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
One concern, but otherwise looks good!
Sorry, something went wrong.
Comment thread
src/reference.js
Outdated
|
|
||
| this._fieldOrders.push( | ||
| new FieldOrder(FieldPath.documentId(), lastDirection) | ||
| ); |
This comment was marked as spam.
This comment was marked as spam.
schmidt-sebastian
force-pushed
the
mrschmidt-cursors
branch
from
ab2bb18 to
b5beba1
Compare
January 11, 2018 03:47
mikelehen
approved these changes
Jan 12, 2018
mikelehen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Nice! Looks good.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewerAssignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for DocumentSnapshots in the Query Cursor API. Related: #98