FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: Add support for environment variable FIRESTORE_PREFER_REST by MarkDuckworth · Pull Request #1848 · googleapis/nodejs-firestore · GitHub

This repository was archived by the owner on Mar 4, 2026. It is now read-only.
/ nodejs-firestore Public archive

feat: Add support for environment variable FIRESTORE_PREFER_REST - #1848

Merged
MarkDuckworth merged 6 commits into
mainfrom
markduckworth/env-var-firestore-prefer-rest
May 15, 2023
ConversationCommits (6)ChecksFiles changed
Merged

feat: Add support for environment variable FIRESTORE_PREFER_REST#1848
MarkDuckworth merged 6 commits into
mainfrom
markduckworth/env-var-firestore-prefer-rest

Conversation

MarkDuckworth commented May 10, 2023

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

MarkDuckworth requested review from a team May 10, 2023 20:37
product-auto-label Bot added size: m Pull request size is medium. api: firestore Issues related to the googleapis/nodejs-firestore API. labels May 10, 2023
MarkDuckworth changed the title Add support for environment variable FIRESTORE_PREFER_REST feat: Add support for environment variable FIRESTORE_PREFER_REST May 11, 2023
dconeybe suggested changes May 11, 2023
View reviewed changes

dconeybe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Overall looks fantastic! Great test coverage and well designed. Thanks for making this improvement.

Comment thread dev/src/index.ts Outdated
Comment thread dev/src/util.ts Outdated
Comment thread dev/test/index.ts
Comment thread dev/test/util.ts Outdated
Comment thread dev/test/util.ts
MarkDuckworth requested a review from dconeybe May 12, 2023 16:58
dconeybe suggested changes May 13, 2023
View reviewed changes
Comment thread dev/src/util.ts Outdated
Comment thread dev/src/util.ts Outdated
Comment thread dev/src/util.ts Outdated
Comment thread dev/test/index.ts
Comment thread dev/test/util.ts Outdated
Comment thread dev/test/util.ts Outdated
MarkDuckworth requested a review from dconeybe May 15, 2023 16:02
dconeybe suggested changes May 15, 2023
View reviewed changes
Comment thread dev/src/util.ts Outdated
MarkDuckworth requested a review from dconeybe May 15, 2023 19:33
MarkDuckworth merged commit 96b1d2a into main May 15, 2023
MarkDuckworth deleted the markduckworth/env-var-firestore-prefer-rest branch May 15, 2023 19:45
release-please Bot mentioned this pull request May 15, 2023
Merged
This was referenced Jul 18, 2023
Closed
Merged
sbhvt mentioned this pull request Mar 4, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
dconeybe dconeybe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: firestore Issues related to the googleapis/nodejs-firestore API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL