fix: align app_name with Cloud ML Job ID in deployed environments - #6624
Open
EaCognitive wants to merge 4 commits into
Open
fix: align app_name with Cloud ML Job ID in deployed environments#6624EaCognitive wants to merge 4 commits into
EaCognitive wants to merge 4 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Updated with current main and adjusted the app-name regression test for the upstream ADK version check. Local validation: uv run ... pytest tests/unit/vertex_adk/test_agent_engine_templates_adk.py -k 'test_default_app_name_uses_agent_engine_id or test_initialization_keeps_explicit_app_name or test_default_app_name_uses_fallback_without_agent_engine_id' -> 3 passed. Requesting maintainer review when available. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When an AdkApp is deployed to Vertex AI Agent Engine, there is often a mismatch between the local app.name and the Resource ID assigned by the backend. The SDK currently uses the local name for artifact lookups, leading to 404 errors because the deployment infrastructure expects the Resource ID.
Solution
Updated AdkApp._app_name() to check for the CLOUD_ML_JOB_ID environment variable. If present (indicating a deployed environment), the method returns this ID, ensuring consistency with the backend's expectations for artifact storage and lookup.
Changes
Verification