| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
This seems like a reasonable approach. Before merging I would like to take a moment and make sure firestore is 'fixed' with the original change as well, just to make sure this isn't fixing the wrong thing :) |
Sorry, something went wrong.
|
Sounds good, let me know when you have info on that. :) |
Sorry, something went wrong.
|
@crwilcox Anything I can do to help this move forward? I accidentally introduced a dependency conflict with a new release of google-api-python-client |
Sorry, something went wrong.
|
+1, quite a few PubSub users are looking forward to the fix, too. |
Sorry, something went wrong.
|
Hi! Is there any ETA for having this merged? We're currently blocked on a bugfix for this in our servers. Thanks! |
Sorry, something went wrong.
Sorry, something went wrong.
|
@space55 @arithmetic1728 The new PubSub release that includes its part of this fix is on the way. |
Sorry, something went wrong.
|
Thanks! I'm excited! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Closes #25.
This PR adds the ability to disable automatically pre-fetching the first item of a stream returned by *-Stream gRPC callables. This hook will be used in PubSub to fix the stalled stream issue, while also not affecting Firestore, since the default behavior is preserved.
I realize the fix is far from ideal, but it's the least ugly among the approaches I tried, e.g. somehow passing the flag through ResumableBidiRpc (it's a messy rabbit hole). On the PubSub side monkeypatching the generated SubscriberClient will be needed, but it's a (relatively) clean one-liner:
If/when we merge this, we should also release it, and then we can add != 1.17.0 to the google-api-core version pin in PubSub.
PR checklist