FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: release 1.6.0 by release-please[bot] · Pull Request #117 · googleapis/python-pubsub · GitHub

This repository was archived by the owner on Mar 9, 2026. It is now read-only.
/ python-pubsub Public archive

chore: release 1.6.0 - #117

Merged
gcf-merge-on-green[bot] merged 5 commits into
masterfrom
release-v1.6.0
Jun 9, 2020
ConversationCommits (5)ChecksFiles changed
Merged

chore: release 1.6.0#117
gcf-merge-on-green[bot] merged 5 commits into
masterfrom
release-v1.6.0

Conversation

release-please Bot commented Jun 9, 2020 •
edited by pradn
Loading

Copy link
Copy Markdown
Contributor

1.6.0 (2020-06-09)

Features

  • Add flow control for message publishing (#96) (06085c4)

Bug Fixes

  • Fix PubSub incompatibility with api-core 1.17.0+ (#103) (c02060f)

Documentation

  • Clarify that Schedulers shouldn't be used with multiple SubscriberClients (#100) (cf9e87c)
  • Fix update subscription/snapshot/topic samples (#113) (e62c38b)

Internal / Testing Changes

  • Re-generated service implementaton using synth: removed experimental notes from the RetryPolicy and filtering features in anticipation of GA, added DetachSubscription (experimental) (#114) (0132a46)
  • Incorporate will_accept() checks into publish() (#108) (6c7677e)

trusted-contributions-gcf Bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 9, 2020
yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020
plamut requested a review from pradn June 9, 2020 22:27
plamut reviewed Jun 9, 2020
View reviewed changes

plamut left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Wait, where is #108?

Answer: The bot did not recognize the type of that PR and did not include it in the release notes, we will edit them manually.

Update: Actually, the bot only included 2 of the 6 commits added since the 1.5.0 release...

trusted-contributions-gcf Bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020
yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020
trusted-contributions-gcf Bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020
plamut suggested changes Jun 9, 2020
View reviewed changes

plamut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We need to update a few URLs...

Comment thread CHANGELOG.md Outdated
yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020
plamut added the automerge Merge the pull request once unit tests and other checks pass. label Jun 9, 2020
plamut mentioned this pull request Jun 9, 2020
Merged
4 tasks
gcf-merge-on-green Bot merged commit 60fe71a into master Jun 9, 2020

yoshi-automation commented Jun 9, 2020

Copy link
Copy Markdown
Contributor

Release is at https://github.com/googleapis/python-pubsub/releases/tag/v1.6.0

busunkim96 commented Jun 10, 2020

Copy link
Copy Markdown
Contributor

@plamut The bot is configured to only add commits of type fix and feat to the changelog. If we want additional types, we can modify the logic.

plamut commented Jun 10, 2020

Copy link
Copy Markdown
Contributor

@busunkim96 That would make sense, probably at least docs should be easy to classify.

Maybe adding a note / warning to the PR description would also be helpful to remind reviewers that CHANGELOG might not include all the commits and should be double-checked?

failure-checker Bot mentioned this pull request Jun 10, 2020
Closed
This was referenced Jun 11, 2020
Closed
Closed
failure-checker Bot mentioned this pull request Jun 23, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
pradn pradn approved these changes
plamut plamut approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

automerge Merge the pull request once unit tests and other checks pass. autorelease: tagged cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL