This repository was archived by the owner on Mar 9, 2026. It is now read-only.
refactor: incorporate will_accept() checks into publish() - #108
Merged
pradn merged 6 commits intoJun 9, 2020
Merged
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
IlyaFaer
commented
May 28, 2020
Comment thread
google/cloud/pubsub_v1/publisher/_batch/base.py
IlyaFaer
marked this pull request as ready for review
May 28, 2020 10:56
pradn
suggested changes
May 28, 2020
pradn
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks for taking this on! I think we need to retain/add some tests. Otherwise, looks good.
Sorry, something went wrong.
Comment thread
tests/unit/pubsub_v1/publisher/batch/test_base.py
Comment thread
tests/unit/pubsub_v1/publisher/batch/test_thread.py
pradn
suggested changes
Jun 5, 2020
Comment thread
tests/unit/pubsub_v1/publisher/batch/test_thread.py
pradn
approved these changes
Jun 5, 2020
pradn
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks, this looks good!
Sorry, something went wrong.
Copy link
Copy Markdown
|
Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR |
Sorry, something went wrong.
1 similar comment
Copy link
Copy Markdown
|
Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR |
Sorry, something went wrong.
Closed
Merged
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Jun 9, 2020
## [1.6.0](https://www.github.com/googleapis/python-pubsub/compare/v1.5.0...v1.6.0) (2020-06-09) ### Features * Add flow control for message publishing ([#96](https://www.github.com/googleapis/python-pubsub/issues/96)) ([06085c4](https://www.github.com/googleapis/python-pubsub/commit/06085c4083b9dccdd50383257799904510bbf3a0)) ### Bug Fixes * Fix PubSub incompatibility with api-core 1.17.0+ ([#103](https://www.github.com/googleapis/python-pubsub/issues/103)) ([c02060f](https://www.github.com/googleapis/python-pubsub/commit/c02060fbbe6e2ca4664bee08d2de10665d41dc0b)) ### Documentation - Clarify that Schedulers shouldn't be used with multiple SubscriberClients ([#100](#100)) ([cf9e87c](cf9e87c)) - Fix update subscription/snapshot/topic samples ([#113](#113)) ([e62c38b](e62c38b)) ### Internal / Testing Changes - Re-generated service implementaton using synth: removed experimental notes from the RetryPolicy and filtering features in anticipation of GA, added DetachSubscription (experimental) ([#114](#114)) ([0132a46](0132a46)) - Incorporate will_accept() checks into publish() ([#108](#108)) ([6c7677e](6c7677e))
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Mar 2, 2026
## [1.6.0](https://www.github.com/googleapis/python-pubsub/compare/v1.5.0...v1.6.0) (2020-06-09) ### Features * Add flow control for message publishing ([#96](https://www.github.com/googleapis/python-pubsub/issues/96)) ([06085c4](https://www.github.com/googleapis/python-pubsub/commit/06085c4083b9dccdd50383257799904510bbf3a0)) ### Bug Fixes * Fix PubSub incompatibility with api-core 1.17.0+ ([#103](https://www.github.com/googleapis/python-pubsub/issues/103)) ([c02060f](https://www.github.com/googleapis/python-pubsub/commit/c02060fbbe6e2ca4664bee08d2de10665d41dc0b)) ### Documentation - Clarify that Schedulers shouldn't be used with multiple SubscriberClients ([#100](googleapis/python-pubsub#100)) ([cf9e87c](googleapis/python-pubsub@cf9e87c)) - Fix update subscription/snapshot/topic samples ([#113](googleapis/python-pubsub#113)) ([e62c38b](googleapis/python-pubsub@e62c38b)) ### Internal / Testing Changes - Re-generated service implementaton using synth: removed experimental notes from the RetryPolicy and filtering features in anticipation of GA, added DetachSubscription (experimental) ([#114](googleapis/python-pubsub#114)) ([0132a46](googleapis/python-pubsub@0132a46)) - Incorporate will_accept() checks into publish() ([#108](googleapis/python-pubsub#108)) ([6c7677e](googleapis/python-pubsub@6c7677e))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #105