FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: add type hints to ClientOptions by rinarakaki · Pull Request #735 · googleapis/python-api-core · GitHub

This repository was archived by the owner on Feb 23, 2026. It is now read-only.
/ python-api-core Public archive

fix: add type hints to ClientOptions - #735

Merged
parthea merged 5 commits into
googleapis:mainfrom
rinarakaki:typing
Oct 19, 2024
Merged

fix: add type hints to ClientOptions#735
parthea merged 5 commits into
googleapis:mainfrom
rinarakaki:typing

Conversation

rinarakaki commented Oct 11, 2024
edited
Loading

Copy link
Copy Markdown
Contributor

Enables googleapis/python-cloud-core#302

I checked:

  • pyright google/api_core/client_options.py

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

rinarakaki requested review from a team October 11, 2024 09:09
product-auto-label Bot added the size: s Pull request size is small. label Oct 11, 2024
rinarakaki changed the title add typing chore: add typing Oct 11, 2024
rinarakaki changed the title chore: add typing fix: add type hints to ClientOption Oct 12, 2024
parthea changed the title fix: add type hints to ClientOption fix: add type hints to ClientOptions Oct 19, 2024

parthea commented Oct 19, 2024

Copy link
Copy Markdown
Contributor

Thanks @rinarakaki !

parthea merged commit b91ed19 into googleapis:main Oct 19, 2024
This was referenced May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL